WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#34761 closed enhancement (fixed)

Posts screen: Improve the "filter by status" links description in the Help tab

Reported by: afercia Owned by: afercia
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: good-first-bug has-patch
Focuses: ui, accessibility Cc:
PR Number:

Description

Noticed a couple of small things in the Help tabs that could be improved a bit:

  • "upper left" is not so useful for screen reader users: references to "visual" positions should be avoided in favor of positions in the document structure; "above the posts list" is better because suggests that it's "before"
  • just four possible post statuses are listed (All, Published, Draft, or Trashed) while there are many others, see screenshot below; maybe a more generic text would be more appropriate and future-proof

https://cldup.com/AbGRVWX24e.png

Attachments (6)

edit-php-fix-text-on-help-tab.diff (1.3 KB) - added by odysseygate 4 years ago.
fixed text on help tab in edit.php
fix-both-plugin-install-php-and-users-php.diff (3.0 KB) - added by odysseygate 4 years ago.
I found "upper left" on both plugin-install.php and users.php. so i fixed them. But in users.php, i didnt change texts to generic 'cause increasing user roles are less possible.
34761.patch (10.9 KB) - added by afercia 4 years ago.
edit.diff (1.3 KB) - added by zakb8 4 years ago.
34761.2.patch (10.9 KB) - added by afercia 3 years ago.
34761.3.patch (10.9 KB) - added by afercia 3 years ago.

Download all attachments as: .zip

Change History (12)

@odysseygate
4 years ago

fixed text on help tab in edit.php

@odysseygate
4 years ago

I found "upper left" on both plugin-install.php and users.php. so i fixed them. But in users.php, i didnt change texts to generic 'cause increasing user roles are less possible.

#1 @pansotdev
4 years ago

<?php
Index: src/wp-admin/edit.php
===================================================================
--- src/wp-admin/edit.php (revision 35729)
+++ src/wp-admin/edit.php (working copy)
@@ -194,7 +194,7 @@
                 '<p>' . __('You can customize the display of this screen&#8217;s contents in a number of ways:') . '</p>' .
                 '<ul>' .
                         '<li>' . __('You can hide/display columns based on your needs and decide how many posts to list per screen using the Screen Options tab.') . '</li>' .
-                        '<li>' . __('You can filter the list of posts by post status using the text links in the upper left to show All, Published, Draft, or Trashed posts. The default view is to show all posts.') . '</li>' .
+                        '<li>' . __('You can filter the list of posts by post status using the text links above the posts list to show kinds of post status like All, Published, Draft, Trash and so on. The default view is to show all posts.') . '</li>' .
                         '<li>' . __('You can view posts in a simple title list or with an excerpt using the Screen Options tab.') . '</li>' .
                         '<li>' . __('You can refine the list to show only posts in a specific category or from a specific month by using the dropdown menus above the posts list. Click the Filter button after making your selection. You also can refine the list by clicking on the post author, category or tag in the posts list.') . '</li>' .
                 '</ul>'

@afercia
4 years ago

#2 @afercia
4 years ago

  • Keywords has-patch added

Refreshed patch merges the previous ones and replaces also references to "upper right". By the way, found many occurrences of "on the left" and "on the right" that should be changed as well.

@zakb8
4 years ago

#3 @DrewAPicture
4 years ago

  • Owner set to afercia
  • Status changed from new to assigned

@afercia
3 years ago

#4 @afercia
3 years ago

  • Milestone changed from Awaiting Review to 4.6

@zakb8 thanks, "to only show posts with that status" sounds better. I'd keep "links above the posts list" though. Refreshed patch.

@afercia
3 years ago

#5 @afercia
3 years ago

Refreshed patch to use a proper single quotation mark.

#6 @afercia
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37680:

Accessibility: Help text improvements.

Avoid references to "visual" positions in favour of positions in the document
structure. The help text shouldn't assume users can see.

Also, in the Posts screen don't mention specific types of posts and use a more
generic text instead.

Props odysseygate, pansotdev, zakb8.
Fixes #34761.

Note: See TracTickets for help on using tickets.