WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34763 closed defect (bug) (fixed)

Updates screen iframes need a title attribute

Reported by: afercia Owned by: afercia
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.4
Component: Administration Keywords: has-patch
Focuses: accessibility Cc:

Description

When updating plugins or themes, the updates screen uses some iframes to display the update progress and for accessibility iframes need a title attribute to describe their contents.

Attachments (3)

34763.patch (2.3 KB) - added by afercia 5 years ago.
34763.2.patch (2.3 KB) - added by afercia 5 years ago.
34763.3.diff (1.9 KB) - added by walbo 5 years ago.

Download all attachments as: .zip

Change History (11)

@afercia
5 years ago

#1 @afercia
5 years ago

  • Keywords has-patch added

The proposed patch adds a title attribute to the relevant iframes. For now, it uses Updating... because it's an already existing translatable string. Wondering if should be something more descriptive or if it's better to keep it simple. Any thoughts more than welcome.

Side note: the iframe height="170px" attribute value shouldn't have a unit measure.

Last edited 5 years ago by afercia (previous) (diff)

#2 @afercia
5 years ago

To clarify, see the screenshot below: the colored background area is one of the iframes to take care of.

https://cldup.com/tTBoZemEtr.PNG

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 years ago

@afercia
5 years ago

#4 @afercia
5 years ago

  • Milestone changed from Awaiting Review to 4.5
  • Owner set to afercia
  • Status changed from new to assigned
  • Version changed from 4.3 to 4.4

Quickly discussed with the accessibility team and agreed to use the string Update progress.

#5 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35854:

Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.

Fixes #34763.

@walbo
5 years ago

#6 @walbo
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The title attributes isn't translatable.

#7 @afercia
5 years ago

Ah! My bad :) Thanks @walbo.

#8 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 35855:

Updates screen: make the new strings introduced in [35854] translatable.

Props walbo.
Fixes #34763.

Note: See TracTickets for help on using tickets.