Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#34763 closed defect (bug) (fixed)

Updates screen iframes need a title attribute

Reported by: afercia Owned by: afercia
Priority: normal Milestone: 4.5
Component: Administration Version: 4.4
Severity: normal Keywords: has-patch
Cc: Focuses: accessibility

Description

When updating plugins or themes, the updates screen uses some iframes to display the update progress and for accessibility iframes need a title attribute to describe their contents.

Attachments (3)

34763.patch (2.3 KB ) - added by afercia 11 years ago.
34763.2.patch (2.3 KB ) - added by afercia 11 years ago.
34763.3.diff (1.9 KB ) - added by walbo 11 years ago.

Download all attachments as: .zip

Change History (11)

@afercia
11 years ago

#1 @afercia
11 years ago

  • Keywords has-patch added

The proposed patch adds a title attribute to the relevant iframes. For now, it uses Updating... because it's an already existing translatable string. Wondering if should be something more descriptive or if it's better to keep it simple. Any thoughts more than welcome.

Side note: the iframe height="170px" attribute value shouldn't have a unit measure.

Last edited 11 years ago by afercia (previous) (diff)

#2 @afercia
11 years ago

To clarify, see the screenshot below: the colored background area is one of the iframes to take care of.

https://cldup.com/tTBoZemEtr.PNG

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


11 years ago

@afercia
11 years ago

#4 @afercia
11 years ago

  • Milestone Awaiting Review4.5
  • Owner set to afercia
  • Status newassigned
  • Version 4.34.4

Quickly discussed with the accessibility team and agreed to use the string Update progress.

#5 @afercia
11 years ago

  • Resolutionfixed
  • Status assignedclosed

In 35854:

Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.

Fixes #34763.

@walbo
11 years ago

#6 @walbo
11 years ago

  • Resolution fixed
  • Status closedreopened

The title attributes isn't translatable.

#7 @afercia
11 years ago

Ah! My bad :) Thanks @walbo.

#8 @afercia
11 years ago

  • Resolutionfixed
  • Status reopenedclosed

In 35855:

Updates screen: make the new strings introduced in [35854] translatable.

Props walbo.
Fixes #34763.

Note: See TracTickets for help on using tickets.