WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34768 closed enhancement (fixed)

Mark WP_REST_Server::get_raw_data as static

Reported by: rmccue Owned by: rmccue
Milestone: 4.4 Priority: low
Severity: normal Version:
Component: REST API Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

This isn't linked to any state in the server instance, and would be handy to use outside of the server class (such as ​in authentication).

This doesn't break BC (as you can call static methods via $this->method fine), but it's also not technically a bug, so potentially too late for 4.4.

Change History (4)

#1 @swissspidy
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.4

As per ​https://wordpress.slack.com/archives/core/p1448251995001841, this can be added before RC.

#2 @ocean90
4 years ago

  • Milestone changed from 4.4 to Future Release

Let's only move it to 4.4 if it has a patch.

#3 @rmccue
4 years ago

  • Owner set to rmccue
  • Resolution set to fixed
  • Status changed from new to closed

In 35741:

REST API: Mark WP_REST_Server::get_raw_data as static.

This is just a utility function for getting the request body, not
tied to the server class.

Fixes #34768.

#4 @rmccue
4 years ago

  • Milestone changed from Future Release to 4.4
Note: See TracTickets for help on using tickets.