Opened 9 years ago
Closed 9 years ago
#34790 closed defect (bug) (fixed)
Fix unit tests after [35739]
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 4.4 |
Component: | General | Keywords: | needs-patch |
Focuses: | Cc: |
Description
Looks like we have some theme-dependent tests which are failing now.
https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/93252288
Attachments (1)
Change History (7)
#2
follow-up:
↓ 5
@
9 years ago
I might suggest not loading a theme when running core unit tests, to prevent the active theme from ever affecting expected core behavior.
#3
@
9 years ago
The easy way would to change the filter to twentysixteen_setup
, or we could work on that @todo
like Daniel mentioned.
#4
@
9 years ago
34790.diff modifies the responsive image tests that were failing after the switch to Twenty Sixteen as the default theme. If we truly want to be able to run these tests without any interference from whichever theme is loaded, we'd need to mock all of the expected data for image uploads, rather than using the current factory methods to create actual attachments from uploaded data.
cc: @joemcgill, @obenland, @westonruter