Media: missing trash when MEDIA_TRASH set to true

[afercia]

Enable the Media trash in your wp-config.php

define( 'MEDIA_TRASH', true );

• go in the Media Library > List mode
• trash an attachment
• the "Trash" option is missing in the Filter select, see screenshot below

As far as I see, introduced in [34256] since $this->is_trash is always false except when explicitly requesting for attachment-filter=trash.

So, the "Trash" option appears just... in the Trash view. In all the other views (All, Images, Audio, etc.) there's the need to check for something else. Previously, there was a check to count the trashed items.

[chacha102]

It doesn't look like the javascript is doing anything fancier than checking if media trash is enabled, and displaying the trash link if it is. So I copied that behavior for the list view.

[chacha102]

Patch for #34795

[chacha102]

Corrected patch file.

[afercia]

Thanks @chacha102, thinking this is one of the ways to solve the issue (maybe should check just for MEDIA_TRASH) with the disadvantage the "Trash" option would always be displayed even when there are no trashed items. This is different from the previous behavior, not arguing, just saying it requires some UI feedback :)

[chacha102]

@afercia Yeah. It is probably worth looking at, considering right now the grid mode will display trash if there isn't anything in it as well.

[afercia]

@chacha102 yep, the grid mode select displays all the options (Images, Audio, Video, etc.) even if there are no items. Maybe worth a separate ticket to consider introducing some consistency.

[wonderboymusic]

In 35752:

Media: show Trash filter for Media list table when MEDIA_TRASH is true.

Props chacha102.
Fixes #34795.