WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 5 months ago

#34808 new defect (bug)

Deprecate get_media_embedded_in_content() and get_tag_regex()

Reported by: azaozz Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch
Focuses: Cc:
PR Number:

Description (last modified by azaozz)

Both are "dead" functions not used anywhere in core. Seem like left overs from the post types code in 3.6.

get_media_embedded_in_content() is buggy: cannot handle nested <object> tags (which were popular few years ago for embedding flash) and doesn't match short ended tags without a slash at the end.

get_tag_regex() is also buggy, see #26674. It was used in get_media_embedded_in_content() before [31574]. Not used anywhere since then.

Attachments (1)

34808.2.diff (1.2 KB) - added by perezlabs 4 years ago.
Added NOTICE or WARNING when any of the functions used. But they are still available until they are completely removed.

Download all attachments as: .zip

Change History (4)

#1 @azaozz
4 years ago

  • Description modified (diff)

@perezlabs
4 years ago

Added NOTICE or WARNING when any of the functions used. But they are still available until they are completely removed.

#2 @perezlabs
4 years ago

@azaozz I just uploaded a patch, I hope it's useful.

#3 @perezlabs
4 years ago

  • Keywords has-patch added
Note: See TracTickets for help on using tickets.