WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34829 closed defect (bug) (worksforme)

Press This - Standard editor redirect broken in version 4.3

Reported by: finnj Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.3.1
Component: Press This Keywords:
Focuses: Cc:

Description

In version 4.2.5 Press This uses get_edit_post_link() to get the link to the standard editor, this has changed in 4.3.1, where it links to the standard post edit screen in the admin panel (the filter is not executed).

In my plugin Frontier Post I have used the filter get_edit_post_link() to change the standard editor to be the front end editor (Frontier Post) - This is now reported broken by users.

Please use the get_edit_post_link() filter again.

Code from ver 4.2.5 (class-wp-press-this.php)

</button>
	<a href="<?php echo esc_url( get_edit_post_link( $post_ID ) ); ?>" class="edit-post-link" style="display: none;" target="_blank"><?php _e( 'Standard Editor' ); ?></a>
			

This has been removed in version 4.3.1

Change History (2)

#1 @kraftbj
4 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

get_edit_post_link is still used: https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-press-this.php#L155

In 4.3.x, with the new split button, we use JS to change a value on the form being submitted, that is then used to determine where the user is sent.

I confirmed using the get_edit_post_link filter that it is respected when choosing the option for Standard Editor. I'd suggest testing it out a bit, disabling this check https://plugins.trac.wordpress.org/browser/frontier-post/trunk/frontier-post.php#L423.

#2 @netweb
4 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.