Flex Sizes In WP_Customize_Cropped_Image_Control Not Working

[stephen.punwasi]

Doesn't appear that the "flex_width" or "flex_height" are working when set to true. Anyone else having this problem?

[stephen.punwasi]

<?php
    $wp_customize->add_setting('cropped_image');
     $wp_customize->add_control( new WP_Customize_Cropped_Image_Control( $wp_customize, 'cropped_image', array(
    'section'     => 'title_tagline',
    'label'       => __( 'Croppable Image' ),
    'flex_width'  => true,
    'flex_height' => true,
    'width'       => 920,
    'height'      => 80,
        ) ) );

Code example tried with the twentyfifteen, just in cast I'm missing something.

[coreymckrill4ttf]

I'm seeing this in 4.4.1 as well. It looks like this is happening because when the script submits the parameters for executing the crop, it sets the destination file dimensions to be whatever the "suggested" width and height are in the Customizer's control definition.

cropDetails.dst_width  = control.params.width;
cropDetails.dst_height = control.params.height;

Changing dst_width and dst_height to equal the normal width and height values in the cropDetails object appears to fix the problem, because then the destination file has the same dimensions as the area selected for the crop. That may not always be the desired outcome, if the cropped file is expected to have a min/max dimension limit, but in that case, it seems like there should probably be other parameters for the WP_Customize_Cropped_Image_Control to specify this behavior.

[stephen.punwasi]

Replying to coreymckrill4ttf:

Sweet, good catch.

[westonruter]

What about 34851.diff​, as a subset of a patch from #36255?

[coreymckrill4ttf]

@westonruter works for me!

[celloexpressions]

This is removed from the latest patch on #36255, so should be good to go here.

[westonruter]

In 37042:

Customize: Add support for flex sizes in CustomizeImageCropper.

Ensures that $flex_width and $flex_height as specified on WP_Customize_Cropped_Image_Control will be honored when a crop is saved.

See #36255.
Fixes #34851.