Opened 9 years ago
Closed 9 years ago
#34862 closed defect (bug) (fixed)
Document wp_delete_term() $args as a hash notation
Reported by: | swissspidy | Owned by: | slushman |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Taxonomy | Keywords: | good-first-bug has-patch commit |
Focuses: | docs | Cc: |
Description
As per the @todo
comment in wp_delete_term()
, the $args
parameter should be documented using hash notation.
Currently the param is only somewhat documented in the function description. Without looking at the code closely you have no idea what it is for. The hash notation would make it a lot more readable.
I guess the docblock deservers some overall improvements anyway.
See the PHP documentation standards for more details.
Attachments (2)
Change History (6)
#2
@
9 years ago
- Milestone changed from Awaiting Review to 4.5
- Owner set to slushman
- Status changed from new to assigned
34862.diff is a small update to the provided patch, moving the description from the DocBlock to the $args
description. Also removing the @todo
and improving the docs for @return
.
#3
@
9 years ago
- Keywords commit added
34862.diff looks great. The only thing missing a description of the default for the optional parameter. You can add it to the end of the description:
* Optional. Array of arguments to override the default term ID. Default empty array.
Changed PHPDoc for $args to use hash notation.