WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#34868 closed defect (bug) (fixed)

Use unmodified $wp_version in wp-includes/update.php

Reported by: nacin Owned by: nacin
Priority: normal Milestone: 4.5
Component: Upgrade/Install Version: 4.3
Severity: normal Keywords:
Cc: Focuses:

Description

[32635] (4.3) accidentally started globalizing $wp_version in wp_version_check() and related functions.

What ends up happening is it becomes global, then including wp-includes/version.php actually overrides the global. Thus, the right information gets reported back to WordPress.org, and the rest of the pageload has an unadulterated $wp_version.

We should still change this back to avoid stomping the global unnecessarily.

Change History (5)

#1 @nacin
11 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 35779:

Updates: Avoid stomping global $wp_version in wp_version_check() and related.

fixes #34868.

#2 @johnbillion
11 years ago

  • Keywords fixed-major added
  • Milestone 4.5 → 4.4.1
  • Resolution fixed
  • Status closed → reopened
  • Version → 4.3

#3 @dd32
11 years ago

As this went unnoticed in 4.3, and doesn't actually cause any major issues IMHO I don't think this really needs backporting.

#4 @dd32
11 years ago

  • Keywords fixed-major removed
  • Milestone 4.4.1 → 4.5
  • Resolution → fixed
  • Status reopened → closed

#5 @DavidAnderson
11 years ago

Relevant: #30499 - the WP version ought to be available as a constant.

Note: See TracTickets for help on using tickets.