WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#34877 closed enhancement (fixed)

dbDelta PHPUnit Improvements

Reported by: charlestonsw Owned by: ocean90
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Extend the phpUnit testing for dbDelta to check for index tests.

Build asserts and tests cases to run through the different flavors of PRIMARY and secondary keys.

Attachments (2)

34877_patch_assert_primary_key.diff (1.0 KB) - added by charlestonsw 5 years ago.
Adds an assert for checking primary key and runs this on existing test.
34877-Fix-typo-compoud_key-to-compound_key.patch (2.3 KB) - added by charlestonsw 5 years ago.
Fix typo in compound key index 'compoud' to 'compound'.

Download all attachments as: .zip

Change History (4)

@charlestonsw
5 years ago

Adds an assert for checking primary key and runs this on existing test.

@charlestonsw
5 years ago

Fix typo in compound key index 'compoud' to 'compound'.

#1 @johnbillion
5 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.5
  • Version trunk deleted

#2 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 36552:

Tests: Add Tests_dbDelta::assertTableHasPrimaryKey().

Also fix a typo in the name for the compound key.

Props charlestonsw.
Fixes #34877.

Note: See TracTickets for help on using tickets.