WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#34884 closed defect (bug) (fixed)

Remove .pot files from Default Themes

Reported by: dd32 Owned by: davidakennedy
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Now that we're pushing all translations through translate.wordpress.org & Language Packs for themes, I think we can consider removing the .pot files from our Default Themes.

The .pot files are only used for when someone wishes to translate the theme using offline tools such as poEdit or similar. Language Packs have removed the need for themes to include the generated po/mo files, so shipping the .pot file (which needs to be updated with each version) now seems redundant.

If someone needs the .pot file, the tools to generate it are open-source, and I believe it may be available from translate.wordpress.org as well.

Attachments (2)

34884.patch (38.8 KB) - added by davidakennedy 4 years ago.
Make default themes (Twenty Twelve to Twenty Fifteen) compatible with WordPress.org translations.
34884.2.patch (39.0 KB) - added by davidakennedy 4 years ago.
Updates patch to include more specific translation project URLs.

Download all attachments as: .zip

Change History (11)

#1 @karmatosed
5 years ago

I think removing the .pot files is a good idea.

#2 @davidakennedy
4 years ago

I can start working on this. Just to verify, we'd want to switch all default themes to using WordPress.org translation packs, yes? So like: load_theme_textdomain( 'theme-slug' ); This is in addition to removing the languages directory and .pot file.

I just wanted to make sure before I started with the patch. I'd probably hit all the themes at once.

#3 @karmatosed
4 years ago

  • Owner set to davidakennedy
  • Status changed from new to assigned

@davidakennedy
4 years ago

Make default themes (Twenty Twelve to Twenty Fifteen) compatible with WordPress.org translations.

#4 @davidakennedy
4 years ago

Adding a bit of detail to this from a conversation I had with @ocean90 awhile back.

Can/Should we go ahead and remove the .pot files for Twenty Eleven and Twenty Ten as well? They wouldn't get the load_theme_textdomain change, right?

#5 @davidakennedy
4 years ago

  • Keywords has-patch added

@davidakennedy
4 years ago

Updates patch to include more specific translation project URLs.

#6 @dd32
4 years ago

34884.2.patch Looks correct to me :)

#7 @karmatosed
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38093:

Remove .pot files from Default Themes
Fixes #34884
Props davidakennedy

#8 @ocean90
4 years ago

  • Milestone changed from Future Release to 4.6

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.