#34884 closed defect (bug) (fixed)
Remove .pot files from Default Themes
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Now that we're pushing all translations through translate.wordpress.org & Language Packs for themes, I think we can consider removing the .pot
files from our Default Themes.
The .pot
files are only used for when someone wishes to translate the theme using offline tools such as poEdit or similar. Language Packs have removed the need for themes to include the generated po/mo files, so shipping the .pot
file (which needs to be updated with each version) now seems redundant.
If someone needs the .pot file, the tools to generate it are open-source, and I believe it may be available from translate.wordpress.org as well.
Attachments (2)
Change History (11)
#2
@
9 years ago
I can start working on this. Just to verify, we'd want to switch all default themes to using WordPress.org translation packs, yes? So like: load_theme_textdomain( 'theme-slug' );
This is in addition to removing the languages
directory and .pot
file.
I just wanted to make sure before I started with the patch. I'd probably hit all the themes at once.
@
9 years ago
Make default themes (Twenty Twelve to Twenty Fifteen) compatible with WordPress.org translations.
#4
@
9 years ago
Adding a bit of detail to this from a conversation I had with @ocean90 awhile back.
- Theme translations started rolling out in 2015. See: https://make.wordpress.org/themes/2015/07/14/theme-translations-on-wordpress-org/
- Necessary changes were made to WordPress in https://core.trac.wordpress.org/changeset/22346 and https://meta.trac.wordpress.org/changeset/709 Should be fine to make this change to themes released with and after 3.5.
- Translations would now happen via https://translate.wordpress.org/ and
.pot
files are no longer needed.
Can/Should we go ahead and remove the .pot
files for Twenty Eleven and Twenty Ten as well? They wouldn't get the load_theme_textdomain
change, right?
#6
@
9 years ago
34884.2.patch Looks correct to me :)
I think removing the .pot files is a good idea.