WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34887 closed defect (bug) (fixed)

Standardize on front end (n.) and front-end (adj.)

Reported by: ocean90 Owned by: ocean90
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: good-first-bug has-patch
Focuses: Cc:
PR Number:

Description

The following is currently used in core:

  • front end: 17 matches across 12 files
  • frontend: 14 matches across 10 files
  • front-end: 13 matches across 5 files

Attachments (5)

34887.diff (15.2 KB) - added by obrienlabs 4 years ago.
34887.1.patch (21.0 KB) - added by thewanderingbrit 4 years ago.
34887.2.patch (26.0 KB) - added by thewanderingbrit 4 years ago.
Same as 34887.1.patch, but includes phrases found in themes
34887.3.diff (40.5 KB) - added by thewanderingbrit 4 years ago.
34887.4.diff (25.2 KB) - added by ocean90 4 years ago.
without swfupload and tinymce

Download all attachments as: .zip

Change History (21)

#1 @obrienlabs
4 years ago

@ocean90 I'm doing some research on this, and it looks like (according to this post from the English group at Stack Exchange) that front end is the right way to say it. The reasoning is front end refers to that part of a hardware or software system that is closest to the user..

According to Merriam-Webster, and example of front-end is: There is no front–end charge at the time of investment.

Best I can tell, frontend, front-end and front end within the WordPress files are referring to the part of the software system closest to the user - so it seems that it should be front end.

I'm working on submitting a patch to reflect front end, but I have 2 questions:

  1. Should I include themes? (e.g. front-end is found in twentytwelve, twentythirteen, twentyfourteen and twentyfifteen)
  2. By this same principle, should back-end and backend be standardized to back end? I'm finding inconsistencies there, too.
Last edited 4 years ago by obrienlabs (previous) (diff)

@obrienlabs
4 years ago

#2 @obrienlabs
4 years ago

  • Keywords has-patch added; needs-patch removed

34887.diff contains only changes to the core WordPress files. It does not address themes nor the back-end, backend, back end inconsistencies.

I will submit a 2nd patch based on those thoughts.

#3 @DrewAPicture
4 years ago

Great research from @obrienlabs in comment:1!

+1 for "front end".

#4 @ocean90
4 years ago

@obrienlabs Both of your resources show that there seems to be a difference between the noun and the adjective, so using "front end" for all cases may be wrong.

I which we could have something like https://gcc.gnu.org/codingconventions.html#Spelling for core too.

#5 follow-up: @obrienlabs
4 years ago

@ocean90 I'll agree that front end may not be good for all cases in future. However, best I can tell it's correct right now. Nothing in the patch references putting something in front of something else (which would be front-end/frontend), rather everything is relating to the part of the software closest to the user (front end).

By this same principle, I think the same can be said for back end. Everything I found in code did not put anything behind something else (back-end/backend). It looked like everything was referenced as being the part of software to the administrator (back end).

However, I'm not an English major and am open to feedback.

Perhaps we could create our own version of https://gcc.gnu.org/codingconventions.html#Spelling and have it tailored for WordPress and have it added to the Make Wordpress Core Handbook?

#6 in reply to: ↑ 5 ; follow-up: @SergeyBiryukov
4 years ago

Replying to obrienlabs:

@ocean90 I'll agree that front end may not be good for all cases in future. However, best I can tell it's correct right now. Nothing in the patch references putting something in front of something else (which would be front-end/frontend), rather everything is relating to the part of the software closest to the user (front end).

If my understanding is correct, "on the front end" (noun) is different from "front-end links", "front-end theme", or "front-end site signups" (adjective), and the latter instances should not be changed.

#8 in reply to: ↑ 6 @thewanderingbrit
4 years ago

Replying to SergeyBiryukov:

Replying to obrienlabs:

@ocean90 I'll agree that front end may not be good for all cases in future. However, best I can tell it's correct right now. Nothing in the patch references putting something in front of something else (which would be front-end/frontend), rather everything is relating to the part of the software closest to the user (front end).

If my understanding is correct, "on the front end" (noun) is different from "front-end links", "front-end theme", or "front-end site signups" (adjective), and the latter instances should not be changed.

@SergeyBiryukov, in all of these instances, front end is still the correct term, as they reference the front end of the site:

  • Front-end links are links on the front end of the site.
  • Front-end theme is the theme visible on the front end of the site.
  • Front-end site signups are site signups from the front end of the site.

This is in contrast to the adjective front-end, which means something that needs to be done before something else can happen. For example, a front-end charge is a charge required before something else can happen as opposed to a charge required on the front end of a site, which would be a front end charge.

I'll look through all instances and confirm that front end is the correct term thoughout and submit a patch. I'll also include revisions in kind for backend/back-end/back end.

What are thoughts on whether this should extend to bundled themes?

@thewanderingbrit
4 years ago

Same as 34887.1.patch, but includes phrases found in themes

This ticket was mentioned in Slack in #core by thewanderingbrit. View the logs.


4 years ago

#10 @thewanderingbrit
4 years ago

With the diff now correctly including the src directory, I believe this patch has everything it needs to go in.

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by thewanderingbrit. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by ocean90. View the logs.


4 years ago

@ocean90
4 years ago

without swfupload and tinymce

#14 follow-up: @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 36709:

Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).

Props obrienlabs, thewanderingbrit.
Fixes #34887.

#15 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to 4.5

#16 in reply to: ↑ 14 @thewanderingbrit
4 years ago

Replying to ocean90:

In 36709:

Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).

Props obrienlabs, thewanderingbrit.
Fixes #34887.

Thanks Dominik, and thanks for tweaking the patch to remove swfupload and tinymce.

Note: See TracTickets for help on using tickets.