WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 4 years ago

#3489 closed enhancement (fixed)

JS AYS prompts need to be standardized

Reported by: markjaquith Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.1
Component: UI Keywords: has-patch
Focuses: Cc:

Description

The JS AYS prompts throughout WordPress could use some love. They're cramped and inconsistently presented.

Suggested format:

  • Drop the periods
  • Change the line breaks to double line breaks, so that there is distinction between the line that tells you what is about to happen and the line that tells you how you can cancel or proceed.
  • Single quotes around %s items and Cancel/OK

Example result:

You are about to delete this comment by 'Mary Smith'

'Cancel' to stop, 'OK' to delete

The only thing I really feel strongly about is the whitespace (it really, really helps with readability)... the other things just bother me because they're inconsistent.

Attachments (1)

3489.diff (1.4 KB) - added by scohoust 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 follow-up: Viper007Bond7 years ago

Why single quote? I kinda prefer double myself.

Dunno about the periods either, but I like the double line break.

comment:2 in reply to: ↑ 1 markjaquith7 years ago

Replying to Viper007Bond:

Why single quote? I kinda prefer double myself.

The best way to get people to express an opinion on what X should be is to tell them that X should be Y. That, and doing doublequotes in this context requires &quote; or \" which makes for somewhat ugly code. But if double quotes are the preferred result, so be it. Consistency is my main goal.

comment:3 foolswisdom7 years ago

  • Milestone changed from 2.2 to 2.3

comment:4 foolswisdom7 years ago

  • Milestone changed from 2.3 to 2.5 (future)

comment:5 pauamma5 years ago

  • Milestone changed from 2.9 to Future Release

comment:6 scohoust5 years ago

  • Component changed from Administration to UI
  • Keywords has-patch added
  • Milestone changed from Future Release to 2.9

As far as I can see, with the trash system in place, only the link manager has these prompts. With the exception of the double line break, all other suggestions have got in anyway.

Patch adds the extra line break for the link manager delete option - assuming this is remaining in 2.9 - I would agree the readability is improved.

scohoust5 years ago

comment:7 azaozz4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Yes, most have been fixed long time ago. Double \n seems better in Safari but not in FF and IE.

Note: See TracTickets for help on using tickets.