Opened 9 years ago
Closed 9 years ago
#34908 closed enhancement (fixed)
Merge similar strings in REST API deprecated function/argument handlers
Reported by: | SergeyBiryukov | Owned by: | rachelbaker |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | REST API | Keywords: | has-patch commit |
Focuses: | docs | Cc: |
Description
In rest_handle_deprecated_function()
: '%1$s (since %2$s; use %3$s instead)'
.
In rest_handle_deprecated_argument()
: '%1$s (since %2$s; %3$s)'
.
Unless I'm missing something, the latter could use the first string too.
Attachments (2)
Change History (8)
#2
@
9 years ago
- Focuses docs added
- Keywords has-patch added; needs-patch good-first-bug removed
- Milestone changed from Awaiting Review to 4.5
- Type changed from defect (bug) to enhancement
34908.patch improves the docs and renames the third argument of rest_handle_deprecated_argument()
to $message
.
#3
in reply to:
↑ 1
@
9 years ago
34908.patch looks good, but the translator comment should be updated as well.
I was confused by "3: new argument name" when translating the string.
#4
@
9 years ago
I updated the translation comment within rest_handle_deprecated_argument()
for the $message
argument in 34908.1.patch. @ocean90 can you review?
Note: See
TracTickets for help on using
tickets.
For
_deprecated_function
, the arguments are$file, $version, $replacement
; for_deprecated_argument
, they're instead$function, $version, $message
. We have the different strings here because functions typically only have a replacement function string, whereas arguments have a sentence explaining it.