WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34909 closed defect (bug) (fixed)

Clean up unused strings in credits.php

Reported by: SergeyBiryukov Owned by: ocean90
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: good-first-bug has-patch
Focuses: Cc:

Description

These strings are no longer used in the API and can probably be removed:

  • Extended Core Team
  • Core Developers
  • Recent Rockstars
  • User Experience Lead
  • Core Committer
  • Guest Committer
  • Developer
  • Designer
  • Docs Committer
  • XML-RPC
  • Internationalization
  • Icon Design

Attachments (1)

34909.patch (820 bytes) - added by Ankit K Gupta 5 years ago.
patch file with updated credits.php

Download all attachments as: .zip

Change History (9)

@Ankit K Gupta
5 years ago

patch file with updated credits.php

#1 @Ankit K Gupta
5 years ago

@SergeyBiryukov I hope, I got you correctly, added the patch file.
Thanks

#2 @Ankit K Gupta
5 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core by wonderboymusic. View the logs.


5 years ago

#4 @ocean90
5 years ago

  • Milestone changed from Awaiting Review to 4.5

#5 follow-up: @nacin
5 years ago

I keep thinking about how we can better represent folks on this page. It's likely harmless to keep most of these around since they've already been translated by 60+ locales, in case we want to use them again.

#6 @SergeyBiryukov
5 years ago

I was struggling with an appropriate translation for "Docs Committer". It was added in [33695], but then Drew became Core Committer, so the translated string was never used, hence the idea to clean them up a bit :)

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#7 in reply to: ↑ 5 @westi
5 years ago

Replying to nacin:

I keep thinking about how we can better represent folks on this page. It's likely harmless to keep most of these around since they've already been translated by 60+ locales, in case we want to use them again.

Won't we still have them in GlotPress's history for these locales if we need to bring them back?

It makes it easier for new locales to get to 100% if we don't keep around unused strings.

#8 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 36554:

Credits: Remove unused strings.

Props Ankit K Gupta.
Fixes #34909.

Note: See TracTickets for help on using tickets.