WordPress.org

Make WordPress Core

Opened 14 years ago

Closed 5 years ago

Last modified 5 years ago

#3491 closed enhancement (wontfix)

new hooks for pingback, trackback?

Reported by: monkinetic Owned by: markjaquith
Milestone: Priority: normal
Severity: normal Version:
Component: Pings/Trackbacks Keywords: needs-refresh dev-feedback
Focuses: Cc:

Description

I'd like to propose two more hooks for Wordpress, one in pingback_ping()
and the other in wp-trackback.php.

background: http://redmonk.net/archives/2006/12/21/voteback/

The first hook would allow plugins to have access to the full text of a
hyperlink on a site that is pinging this site, before the comment is
built for a ping.

The second would allow plugins to have access to the full post data for
a trackback before the comment is built.

Attachments (3)

trackback_extend_comment.patch (498 bytes) - added by monkinetic 14 years ago.
This patch adds a call to a new hook before a trackback is saved
pingback_extend_comment.patch (1.1 KB) - added by monkinetic 14 years ago.
This patch adds a new hook before a pingback is saved
3491.diff (1.6 KB) - added by sorich87 10 years ago.

Download all attachments as: .zip

Change History (16)

@monkinetic
14 years ago

This patch adds a call to a new hook before a trackback is saved

@monkinetic
14 years ago

This patch adds a new hook before a pingback is saved

#1 @shorty114
14 years ago

  • Keywords has-patch added; pingback trackback hooks removed

Looks good. Can we fit this into 2.0.6 or is that feature frozen?

#2 @markjaquith
14 years ago

  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

The trackback_extend_comment.patch isn't needed... you can access the same data in the preprocess_comment hook. The filter is run on the first line of wp_new_comment() and $_POST is a superglobal, so you always have access to it.

The pingback excerpt generating code is flawed, which looking at your pingback patch brought attention to. See #3495 So that code will likely be changing... I'll revisit this once that's taken care of. The best way to handle this will likely be to stick that extra data you need into the commentdata array. That way no new filters are needed at all (again, you'd just use preprocess_comment).

#3 @monkinetic
14 years ago

Thanks Mark. Naturally, I figured out that trackback_extend_comment was not needed sometme *after* I posted the patch. Oh well. Is there a milestone you'd expect the new pingback data to show up in?

#4 @foolswisdom
14 years ago

  • Milestone changed from 2.2 to 2.3

#5 @ryan
13 years ago

  • Milestone changed from 2.3 to 2.4

#6 @pishmishy
13 years ago

  • Milestone changed from 2.5 to 2.6

Feature request so bumping to 2.6 for feature freeze.

#7 @Denis-de-Bernardy
11 years ago

  • Component changed from General to Pings/Trackbacks

#8 @Denis-de-Bernardy
11 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.9 to Future Release

@sorich87
10 years ago

#9 @chriscct7
6 years ago

  • Keywords needs-refresh dev-feedback added; needs-patch removed

The patch needs to be refreshed and the ticket re-evaluated. From Mark's comments, it may not longer be valid

This ticket was mentioned in Slack in #core by dshanske. View the logs.


5 years ago

#11 @dshanske
5 years ago

  • Resolution set to wontfix
  • Status changed from accepted to closed

Closed due #34141.

The solution here predates the creation of comment metadata, and a better solution is to save the trackback data and pingback data once processed into comment meta if someone wants to use them and to make the necessary modifications for that to occur.

#12 @DrewAPicture
5 years ago

  • Milestone Future Release deleted

This ticket was mentioned in Slack in #core by dshanske. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.