Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#34910 closed defect (bug) (fixed)

Add wp-admin/includes/network.php to makepot.php

Reported by: SergeyBiryukov Owned by: ocean90
Priority: normal Milestone: WordPress.org
Component: I18N Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description (last modified by SergeyBiryukov)

Since [34023], ~70 strings that were previously in Network Admin project, are now in the main Administration project (and are unnecessarily loaded for single sites), because makepot.php doesn't know about the new file.

Attachments (2)

34910.patch​ (1.7 KB ) - added by SergeyBiryukov 11 years ago.
34910.2.patch​ (1.9 KB ) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
11 years ago

  • Description modified (diff)

#2 @SergeyBiryukov
11 years ago

  • Description modified (diff)

#3 @ocean90
11 years ago

  • Milestone Awaiting Review → WordPress.org

I'm not going to change this for the 4.4 release because it can be done at a later date too.

#4 @SergeyBiryukov
11 years ago

Works for me :)

Seems like wp-admin/includes/ms.php should be added too, as it contains multisite strings as well, see [34025].

Same for wp-admin/includes/class-wp-ms.*, see 34910.2.patch​.

Perhaps MakePOT::wp_admin() could just use $this->ms_files to reduce duplication?

#5 @ocean90
11 years ago

Updated wp_network_admin() in ​https://i18n.trac.wordpress.org/changeset/40330 to include wp-admin/includes/class-wp-ms.* and wp-admin/includes/network.php.
$this->ms_files can't be used because it's for all multisite strings, this only about network admin strings.

#6 @netweb
11 years ago

Related: #34749

#7 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolution → fixed
  • Status new → closed

In 36752:

Note: See TracTickets for help on using tickets.