Opened 9 years ago
Closed 9 years ago
#34910 closed defect (bug) (fixed)
Add wp-admin/includes/network.php to makepot.php
Reported by: | SergeyBiryukov | Owned by: | ocean90 |
---|---|---|---|
Milestone: | WordPress.org | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch |
Focuses: | Cc: |
Description (last modified by )
Since [34023], ~70 strings that were previously in Network Admin project, are now in the main Administration project (and are unnecessarily loaded for single sites), because makepot.php
doesn't know about the new file.
Attachments (2)
Change History (9)
#4
@
9 years ago
Works for me :)
Seems like wp-admin/includes/ms.php
should be added too, as it contains multisite strings as well, see [34025].
Same for wp-admin/includes/class-wp-ms.*
, see 34910.2.patch.
Perhaps MakePOT::wp_admin()
could just use $this->ms_files
to reduce duplication?
#5
@
9 years ago
Updated wp_network_admin()
in https://i18n.trac.wordpress.org/changeset/40330 to include wp-admin/includes/class-wp-ms.*
and wp-admin/includes/network.php
.
$this->ms_files
can't be used because it's for all multisite strings, this only about network admin strings.
I'm not going to change this for the 4.4 release because it can be done at a later date too.