![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 11 years ago
Closed 11 years ago
#34914 closed defect (bug) (fixed)
Merge 'View' strings with the same context
| Reported by: | SergeyBiryukov | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.5 |
| Component: | Administration | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
[34006] added _x( 'View', 'verb' ) as a row action for approved comments in Dashboard.
We already have exactly the same string in list tables, but without a context.
We should either add the 'verb' context to other instances too, or remove it from this instance.
Attachments (2)
Change History (7)
This ticket was mentioned in Slack in #core by wonderboymusic. View the logs.
11 years ago
#4
@
11 years ago
Going with 34006.diff, as it was an accidental change, and if we use __( 'View' ) anywhere else, the strings would become inconsistent again.
There is no _x( 'View', 'noun' ) in core yet, and if we do need additional context at some point, we can reconsider this.
Note:
See TracTickets
for help on using tickets.
Added 'verb' context to other instances of 'View'