WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#34914 closed defect (bug) (fixed)

Merge 'View' strings with the same context

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:
PR Number:

Description

[34006] added _x( 'View', 'verb' ) as a row action for approved comments in Dashboard.

We already have exactly the same string in list tables, but without a context.

We should either add the 'verb' context to other instances too, or remove it from this instance.

Attachments (2)

34006.diff (579 bytes) - added by MikeHansenMe 4 years ago.
34914.patch (4.2 KB) - added by subharanjan 4 years ago.
Added 'verb' context to other instances of 'View'

Download all attachments as: .zip

Change History (7)

#1 @wonderboymusic
4 years ago

  • Milestone changed from Awaiting Review to 4.5

This ticket was mentioned in Slack in #core by wonderboymusic. View the logs.


4 years ago

@MikeHansenMe
4 years ago

@subharanjan
4 years ago

Added 'verb' context to other instances of 'View'

#3 @swissspidy
4 years ago

  • Keywords has-patch added; needs-patch removed

#4 @SergeyBiryukov
4 years ago

Going with 34006.diff, as it was an accidental change, and if we use __( 'View' ) anywhere else, the strings would become inconsistent again.

There is no _x( 'View', 'noun' ) in core yet, and if we do need additional context at some point, we can reconsider this.

#5 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35900:

List tables: After [34006], remove unnecessary context from 'View' string, for consistency with other strings in the same context.

Props MikeHansenMe, subharanjan.
Fixes #34914.

Note: See TracTickets for help on using tickets.