Consider suppressing error notices for REST API requests

[danielbachhuber]

We should consider suppressing error notices for REST API requests, as they can break the response.

Originally ​https://github.com/WP-API/WP-API/issues/477

[chriscct7]

I actually like that they break responses right now, because it makes it easier to find bugs. If the concern is breaking responses for a production server, they could turn off notices in their PHP.ini file (which should be done on production anyways)

[pathartl]

Replying to chriscct7:

I actually like that they break responses right now, because it makes it easier to find bugs. If the concern is breaking responses for a production server, they could turn off notices in their PHP.ini file (which should be done on production anyways)

If this type of thing were to be considered, I would think it would make more sense to have it controlled by WP_DEBUG. Those on hosted solutions wouldn't have control over it if it were in PHP.ini and it doesn't really make sense to separate it out from WordPress.

[DrewAPicture]

Looks like piggybacking on wp_debug_mode() would be the way to go, similarly, as @nacin ​pointed out on GitHub, to how we suppress notices for XMLRPC requests.

[SergeyBiryukov]

Related: #26262

[rockwell15]

Does that work well?

[rachelbaker]

@rockwell15 Thanks for your patch. It looks good, but can you refresh it to be against the svn root directory?

The location of the file being patched here should be src/wp-includes/load.php.

[rachelbaker]

In 36530:

REST API: Don’t display errors during REST API requests.

Uses wp_debug_mode() to prevent response from being broken by debug errors. Matches similar behavior of the XML-RPC API.

Props rockwell15.

Fixes #34915.

[ocean90]

In 36571:

Don't display errors during Ajax requests.

See #34915 for REST and #23811 for XML-RPC.

Props pento.
Fixes #26262.