WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #34931, comment 2


Ignore:
Timestamp:
12/09/2015 10:06:04 AM (5 years ago)
Author:
swissspidy
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34931, comment 2

    initial v1  
    33I'll leave it to others to decide whether this filter makes sense.
    44
    5 From a code point of view I'd suggest you to follow the [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#4-hooks-actions-and-filters inline documentation standards] for filters. Perhaps putting `$ratio_diff`= apply_filters( 'max_srcset_image_diff_ratio', 0.002 )` on a new line for increased readability.
     5From a code point of view I'd suggest you to follow the [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#4-hooks-actions-and-filters inline documentation standards] for filters. Perhaps putting `$ratio_diff = apply_filters( 'max_srcset_image_diff_ratio', 0.002 )` on a new line for increased readability.