Make WordPress Core

Opened 17 years ago

Closed 15 years ago

Last modified 15 years ago

#3494 closed enhancement (wontfix)

Comments filtered for XHTML validity multiple times

Reported by: markjaquith's profile markjaquith Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.1
Component: Optimization Keywords:
Focuses: Cc:


#2714 introduced comment_text() XHTML validity forcing.

Now, if the balanceTags option is on, WP is filtering comments on their way into the database as well as on the way out. pre_comment_content and comment_save_pre both run the comment content through balanceTags().

I think that comments, as third-party data whose XHTML invalidity can ruin your blog or your WP admin, should always be filtered for XHTML validity.

The best solution IMO would be to have comments always XHTML filtered on the way into the database (that is, run force_balance_tags() on pre_comment_content and comment_save_pre and remove the call to force_balance_tags() on comment_text() )

That's how content is filtered, and that'd be the least processor intensive.

Change History (4)

#1 @foolswisdom
17 years ago

  • Milestone changed from 2.2 to 2.3

#2 @foolswisdom
17 years ago

  • Milestone changed from 2.3 to 2.5 (future)

#3 @markjaquith
15 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Change of heart. Other filters could be messing around, and we want to make absolutely sure comments have tags balanced.

#4 @jacobsantos
15 years ago

  • Milestone 2.9 deleted
Note: See TracTickets for help on using tickets.