Comments Created Without a `comment_post_ID` Are Not Editable

[rachelbaker]

If a comment is created via wp_insert_comment() without the optional comment_post_ID parameter, the value in the database is 0. The comment will display in the Comments list table, but if you try to edit the comment your changes never save.

This is (at least in part) due to the following code from src/wp-includes/comment.php:

// Make sure that the comment post ID is valid (if specified).
	if ( isset( $commentarr['comment_post_ID'] ) && ! get_post( $commentarr['comment_post_ID'] ) ) {
		return 0;
}

The check here should be changed to ! empty() since isset() would be true for a 0 value.

[SergeyBiryukov]

Introduced in [31195].

[boonebgorges]

Patch looks good. Would be nice to have a unit test describing the bug so we don't do this again.

[rachelbaker]

Added unit tests

[rachelbaker]

@boonebgorges Added unit tests in 34954.1.patch​, can you review the tests for me?

[boonebgorges]

Thanks @rachelbaker - Test looks good, though I'd change assertEquals to assertSame. Side note: pretty cool how wp_update_comment() returns an integer.

[rachelbaker]

In 35853:

Comments: Comments don’t need no Post ID when created, so they don’t be needing one to be edited.

In wp_update_comment() only check if the given comment_post_ID is valid if it isn’t 0. This allows comments that were created programmatically via wp_insert_comment() without the (optional) comment_post_ID parameter to be edited.

Props subharanjan for the initial patch.
Fixes #34954