WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#34975 closed defect (bug) (fixed)

Explicitly globalize $wp_local_package

Reported by: danielbachhuber's profile danielbachhuber Owned by: ocean90's profile ocean90
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Bootstrap/Load Keywords: has-patch
Focuses: Cc:

Description

It's included in version.php for non-US English locales.

Discovered in ​https://github.com/wp-cli/wp-cli/pull/2287

Attachments (1)

34975.1.diff​ (611 bytes) - added by danielbachhuber 9 years ago.

Download all attachments as: .zip

Change History (3)

@danielbachhuber
9 years ago

#1 @danielbachhuber
9 years ago

We have some instances of isset( $wp_local_package ) in the codebase, but the check performs as expected:

salty-wordpress ➜  wordpress-test.dev  wp shell
wp> global $wp_local_package;
wp> isset( $wp_local_package );
bool(false)

#2 @ocean90
9 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 36557:

Make $wp_local_package explicitly global in wp-settings.php.

Props danielbachhuber.
Fixes #34975.

Note: See TracTickets for help on using tickets.