Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #34995, comment 7


Ignore:
Timestamp:
12/11/2015 08:00:32 AM (6 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34995, comment 7

    initial v1  
    33[34465] made the `$index` argument of `dynamic_sidebar()` case-sensitive, because it no longer runs through `sanitize_title()`.
    44
    5 The unit test added in that changeset doesn't make much sense to me, because it doesn't seem to test the reported issue with using special characters in sidebar ID. It does not even use the sidebar it registers. Instead, it relies on the assumption that the current default theme does not register a sidebar named `'Sidebar 1'`, and verifies that `dynamic_sidebar( 'Sidebar 1' )` does not display the sidebar registered with `'id' => 'sidebar-1'`. This might be a related issue, but it's not what was reported in #23423.
     5The unit test added in that changeset doesn't make much sense to me, because it doesn't seem to test the reported issue with using special characters in sidebar ID. It does not even use the sidebar it registers. Instead, it relies on the assumption that the current default theme does not register a sidebar named `'Sidebar 1'`, and verifies that `dynamic_sidebar( 'Sidebar 1' )` does not display the sidebar registered with `'id' => 'sidebar-1'`. This might be a related issue, but it's not what was reported in #23423. It's more related to #22116.
    66
    77Is there a reason to use special characters in sidebar IDs? Perhaps [34465] should be reverted, with #23423 closed as invalid, or pushed to a future release pending a proper fix.