All code should adhere to WordPress coding standards

[barry]

[34981] committed by @dd32 does not adhere to the WordPress ​Coding Standards

Specifically:

Files should be named descriptively using lowercase letters. Hyphens should separate words.

I understand this is an upstream library, but renaming the files and their includes is trivial and makes things much more consistent. There is a precedent already as we do this with PHPMailer and probably other 3rd party libs.

[dd32]

The libraries which we have renamed are also single file libraries (phpmailer, phpass, pemftp). Other libraries we use (id3, diff, simplepie, etc) don't get renamed either - they just don't include underscores in filenames.

For simplicity, I opted to include the library as-is to reduce the maintenance burden of upgrading it, and although underscores are not in line with our naming, cause no ill effects (which is also why we keep TinyMCE as-is, also including underscores).

[nacin]

For reference, the changeset being referred to is ​https://build.trac.wordpress.org/changeset/34946 or [34981].

Agreed with @dd32 on this one.

[swissspidy]

Closing as two lead developers agree that it doesn't make sense to rename these files. I agree with them as well :-)