WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#35004 closed defect (bug) (wontfix)

All code should adhere to WordPress coding standards

Reported by: barry Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6
Component: External Libraries Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

[34981] committed by @dd32 does not adhere to the WordPress Coding Standards

Specifically:

Files should be named descriptively using lowercase letters. Hyphens should separate words.

I understand this is an upstream library, but renaming the files and their includes is trivial and makes things much more consistent. There is a precedent already as we do this with PHPMailer and probably other 3rd party libs.

Change History (4)

#1 @dd32
5 years ago

  • Keywords close 2nd-opinion added

The libraries which we have renamed are also single file libraries (phpmailer, phpass, pemftp). Other libraries we use (id3, diff, simplepie, etc) don't get renamed either - they just don't include underscores in filenames.

For simplicity, I opted to include the library as-is to reduce the maintenance burden of upgrading it, and although underscores are not in line with our naming, cause no ill effects (which is also why we keep TinyMCE as-is, also including underscores).

#2 @nacin
5 years ago

For reference, the changeset being referred to is https://build.trac.wordpress.org/changeset/34946 or [34981].

Agreed with @dd32 on this one.

#3 @SergeyBiryukov
5 years ago

  • Description modified (diff)

#4 @swissspidy
5 years ago

  • Keywords close 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as two lead developers agree that it doesn't make sense to rename these files. I agree with them as well :-)

Note: See TracTickets for help on using tickets.