WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 4 months ago

#35018 new defect (bug)

The authentication check modal dialog appears just once

Reported by: afercia Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.4
Component: Login and Registration Keywords: has-patch
Focuses: ui, javascript Cc:
PR Number:

Description

Noticed while investigating on #34951. To reproduce:

  1. edit a post
  2. open a new tab, go in some other admin screen and log out
  3. in the tab with the edit post screen, after a while the authentication modal dialog appears
  4. login again using the modal dialog
  5. repeat step 2

The authentication modal dialog won't appear again because, as far as I see, when it gets hidden the custom event that triggers the dialog gets removed. See hide() in /wp-includes/js/wp-auth-check.js

$(document).off( 'heartbeat-tick.wp-auth-check' );

Not sure why the event is removed.

Attachments (1)

35018.patch (801 bytes) - added by walbo 3 years ago.

Download all attachments as: .zip

Change History (3)

#1 @swissspidy
4 years ago

  • Keywords needs-patch added

@walbo
3 years ago

#2 @walbo
3 years ago

  • Keywords has-patch added; needs-patch removed

The patch fixes so the modal dialog appear again after second logout. Still removes the event if you close the modal by clicking the close button.

Note: See TracTickets for help on using tickets.