Changes between Initial Version and Version 1 of Ticket #35030, comment 19
- Timestamp:
- 03/17/2016 01:31:43 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #35030, comment 19
initial v1 1 @jaspermdegroot looks like the patch needs a refresh, but generally, this looks good. Wondering if we could use an `array_ push()` to prepend a source when `$is_src` is true to avoid using two separate array. We should also add some inline docs explaining why we're forcing the `src` to the front of the `srcset` list.1 @jaspermdegroot looks like the patch needs a refresh, but generally, this looks good. Wondering if we could use an `array_unshift()` to prepend a source when `$is_src` is true to avoid using two separate array. We should also add some inline docs explaining why we're forcing the `src` to the front of the `srcset` list.