Change wording on password protect form to not use submit

[karmatosed]

The password protect form uses the word 'submit'. As seen here:

Submit isn't a great word to use for forms at all and there are much better calls to add something. It's a small but friendlier change to remove this word and replace with something else.

There are a few options as to what we could replace it with:

• Add password
• Go
• Enter
• View post

Even if the above aren't considered good options, I am sure we can come up with something better than 'submit'.

[SergeyBiryukov]

Submit isn't a great word to use for forms at all

Just curious, is it because it's too generic?

Found two more instances in core:

• wp-admin/setup-config.php​
• wp-admin/includes/dashboard.php​

Of the above suggestions, "View post" seems the most appropriate, but it can also get quite long when translated.

[karmatosed]

@SergeyBiryukov it's not because it's generic only. That word is commanding and not in a good way. Submit has a lot of not particularly good meaning in some cultures as a word beyond 'send the form'. It can be seen as impolite too as commanding someone to do something. Usually changing it is a low hanging fruit towards making interactions more human.

Beyond the meaning, having it be more exact to context is also beneficial. A few extra words over better meaning and context is a win.

[SergeyBiryukov]

Thanks, I thought something like that might be the case.

[karmatosed]

A patch to start with for the changes.

[karmatosed]

I've updated this to remove all apart from the password as changes for now. There are a few 'Submits' and it would be good to deal with all at some point, but lets focus on this ticket for now.

Here is what it originally looked like:

This is what the patch creates:

@melchoyce going to ping you here to see what you think also - thanks.

[karmatosed]

Second patch

[melchoyce]

Changing this label makes sense, but I'm worried that on themes like in your screenshot above, where the button and input are separate, people might zero in on "View Post" and totally ignore the password field, since it's not a traditional form label.

[karmatosed]

@melchoyce what wording do you think could work? Some possible ideas would be:

• Reveal post
• Add password
• Show post
• Enter password (enter probably is not great either)

I'm open to suggestions as mainly 'submit' that is the issue here.

[adambecker]

How about just "OK"?

[kellychoffman]

I like *Enter*:

You land on a page. Its password protected. You have to type the password to enter.

Its also most likely the key you'll press instead of actually hitting the button.

[melchoyce]

I agree with @kellychoffman — I think "Enter" works. @karmatosed — can you talk about why you don't like it?

[karmatosed]

So, I don't not like more than submit - pretty much anything is better than we have now. I feel 'enter' is a slightly less human term as you aren't actually entering and it has a colder, tech focuses leaning. Ultimatly, I felt it was the least awesome if my options suggested.

That said, I'd totally be into enter over submit :) Happy to go with what people think works.

Want me to rustle up an patch using enter? Are you suggesting 'Enter' or 'Enter Password?'

[melchoyce]

Replying to karmatosed:

So, I don't not like more than submit - pretty much anything is better than we have now. I feel 'enter' is a slightly less human term as you aren't actually entering and it has a colder, tech focuses leaning. Ultimatly, I felt it was the least awesome if my options suggested.

That said, I'd totally be into enter over submit :) Happy to go with what people think works.

Want me to rustle up an patch using enter? Are you suggesting 'Enter' or 'Enter Password?'

I think just "Enter" works. Thanks!

[karmatosed]

New patch is up and looks like this:

[melchoyce]

Looks good. I was chatting with @helen about this and she brought up i18n. Is there anything we need to do to provide context for this change to translators? @SergeyBiryukov since you're watching this ticket, do you know?

Once I have the go-ahead I'll commit. :)

[SergeyBiryukov]

Replying to melchoyce:

Is there anything we need to do to provide context for this change to translators?

I would use esc_attr_x() with a context just in case, e.g. esc_attr_x( 'Enter', 'post password form' ). Looks good to me otherwise.

[karmatosed]

@melchoyce and @SergeyBiryukov I've added a patch to pick up the translation issues. Thanks for noticing and suggesting a fix there.

[melchoyce]

In 36685:

Forms: Swap "Submit" button label for "Enter" on password-protected pages.

Props karmatosed, SergeyBiryukov

See #35042.