WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#35042 closed enhancement (fixed)

Change wording on password protect form to not use submit

Reported by: karmatosed Owned by: melchoyce
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: ux-feedback has-patch
Focuses: ui Cc:

Description

The password protect form uses the word 'submit'. As seen here:

https://cldup.com/yjiaapVdd8.png

Submit isn't a great word to use for forms at all and there are much better calls to add something. It's a small but friendlier change to remove this word and replace with something else.

There are a few options as to what we could replace it with:

  • Add password
  • Go
  • Enter
  • View post

Even if the above aren't considered good options, I am sure we can come up with something better than 'submit'.

Attachments (4)

35042.diff (2.3 KB) - added by karmatosed 6 years ago.
A patch to start with for the changes.
35042-2.diff (1.0 KB) - added by karmatosed 6 years ago.
Second patch
35042-3.diff (1020 bytes) - added by karmatosed 6 years ago.
35042-4.diff (1.0 KB) - added by karmatosed 6 years ago.

Download all attachments as: .zip

Change History (26)

#1 @karmatosed
6 years ago

  • Keywords ux-feedback added

#2 @SergeyBiryukov
6 years ago

Submit isn't a great word to use for forms at all

Just curious, is it because it's too generic?

Found two more instances in core:

Of the above suggestions, "View post" seems the most appropriate, but it can also get quite long when translated.

#3 @johnbillion
6 years ago

  • Version trunk deleted

#4 @karmatosed
6 years ago

@SergeyBiryukov it's not because it's generic only. That word is commanding and not in a good way. Submit has a lot of not particularly good meaning in some cultures as a word beyond 'send the form'. It can be seen as impolite too as commanding someone to do something. Usually changing it is a low hanging fruit towards making interactions more human.

Beyond the meaning, having it be more exact to context is also beneficial. A few extra words over better meaning and context is a win.

Last edited 6 years ago by karmatosed (previous) (diff)

#5 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.5

Thanks, I thought something like that might be the case.

@karmatosed
6 years ago

A patch to start with for the changes.

#6 @karmatosed
6 years ago

  • Keywords has-patch added

#7 @karmatosed
6 years ago

I've updated this to remove all apart from the password as changes for now. There are a few 'Submits' and it would be good to deal with all at some point, but lets focus on this ticket for now.

Here is what it originally looked like:

https://cldup.com/cJY192jE7n.png

This is what the patch creates:

https://cldup.com/uNnuGo0gvG.png

@melchoyce going to ping you here to see what you think also - thanks.

Last edited 6 years ago by karmatosed (previous) (diff)

@karmatosed
6 years ago

Second patch

#8 @melchoyce
6 years ago

Changing this label makes sense, but I'm worried that on themes like in your screenshot above, where the button and input are separate, people might zero in on "View Post" and totally ignore the password field, since it's not a traditional form label.

#9 follow-up: @karmatosed
6 years ago

@melchoyce what wording do you think could work? Some possible ideas would be:

  • Reveal post
  • Add password
  • Show post
  • Enter password (enter probably is not great either)

I'm open to suggestions as mainly 'submit' that is the issue here.

#10 in reply to: ↑ 9 @adambecker
6 years ago

How about just "OK"?

#11 @kellychoffman
6 years ago

I like *Enter*:

You land on a page. Its password protected. You have to type the password to enter.

Its also most likely the key you'll press instead of actually hitting the button.

#12 @melchoyce
6 years ago

I agree with @kellychoffman — I think "Enter" works. @karmatosed — can you talk about why you don't like it?

#13 follow-up: @karmatosed
6 years ago

So, I don't not like more than submit - pretty much anything is better than we have now. I feel 'enter' is a slightly less human term as you aren't actually entering and it has a colder, tech focuses leaning. Ultimatly, I felt it was the least awesome if my options suggested.

That said, I'd totally be into enter over submit :) Happy to go with what people think works.

Want me to rustle up an patch using enter? Are you suggesting 'Enter' or 'Enter Password?'

Last edited 6 years ago by karmatosed (previous) (diff)

#14 in reply to: ↑ 13 @melchoyce
6 years ago

Replying to karmatosed:

So, I don't not like more than submit - pretty much anything is better than we have now. I feel 'enter' is a slightly less human term as you aren't actually entering and it has a colder, tech focuses leaning. Ultimatly, I felt it was the least awesome if my options suggested.

That said, I'd totally be into enter over submit :) Happy to go with what people think works.

Want me to rustle up an patch using enter? Are you suggesting 'Enter' or 'Enter Password?'

I think just "Enter" works. Thanks!

@karmatosed
6 years ago

#15 @karmatosed
6 years ago

New patch is up and looks like this:

https://cldup.com/seKfthEEfr.png

#16 follow-up: @melchoyce
6 years ago

Looks good. I was chatting with @helen about this and she brought up i18n. Is there anything we need to do to provide context for this change to translators? @SergeyBiryukov since you're watching this ticket, do you know?

Once I have the go-ahead I'll commit. :)

#17 in reply to: ↑ 16 @SergeyBiryukov
6 years ago

Replying to melchoyce:

Is there anything we need to do to provide context for this change to translators?

I would use esc_attr_x() with a context just in case, e.g. esc_attr_x( 'Enter', 'post password form' ). Looks good to me otherwise.

@karmatosed
6 years ago

#18 @karmatosed
6 years ago

@melchoyce and @SergeyBiryukov I've added a patch to pick up the translation issues. Thanks for noticing and suggesting a fix there.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


6 years ago

#20 @SergeyBiryukov
6 years ago

  • Owner set to melchoyce
  • Status changed from new to assigned

#21 @melchoyce
6 years ago

In 36685:

Forms: Swap "Submit" button label for "Enter" on password-protected pages.

Props karmatosed, SergeyBiryukov

See #35042.

#22 @melchoyce
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.