WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#35073 closed enhancement (fixed)

Unit tests for before_last_bar

Reported by: realloc Owned by: SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

There is no unit test for before_last_bar.

Attachments (1)

35073.diff (1.1 KB) - added by realloc 3 years ago.
WordPress coding standards and unit test for before_last_bar

Download all attachments as: .zip

Change History (5)

@realloc
3 years ago

WordPress coding standards and unit test for before_last_bar

#1 @TobiasBg
3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.5
  • Version trunk deleted

#2 @SergeyBiryukov
3 years ago

The function seems trivial enough, not sure if a test for strrpos() and substr() is really necessary. But I guess it wouldn't hurt either :)

#3 @realloc
3 years ago

Yes you're probably right but I want to go ahead with the testing in this component and red somewhere that you guys prefer to have small and precise instead of monster commits. ;)

#4 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35959:

I18N: Add a unit test for before_last_bar().

Props realloc.
Fixes #35073.

Note: See TracTickets for help on using tickets.