WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #35075, comment 12


Ignore:
Timestamp:
01/07/2016 04:27:14 PM (9 years ago)
Author:
jason_the_adams
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #35075, comment 12

    initial v1  
    22> OK. It would also be nice to have unit tests demonstrating that the cache is sensitive to custom query vars.
    33
    4 I went to write the test, and interestingly enough, I found an "inverse" test in tests/comment/query.php: test_comment_cache_key_should_ignore_custom_params which relates to #22400. I see that @wonderboymusic added the `wp_array_slice_assoc` in [28460].
     4I went to write the test and, interestingly enough, I found an "inverse" test in tests/comment/query.php: test_comment_cache_key_should_ignore_custom_params which relates to #22400. I see that @wonderboymusic added the `wp_array_slice_assoc` in [28460].
    55
    66This tests asserts that only one query is performed when a custom query_var is introduced, when I would assert that there should be two. What's the protocol in this case? Should I modify/remove the existing test?