Missing Change Theme button when there are only two themes available

[igmoweb]

When you have two themes in your installation, Change Theme button in Customizer is missing. I guess this is not a expected behavior, isn't it?

My thoughts:

It looks like in class-wp-customize-themes-section.php, line no. 49:

if ( count( $this->controls ) > 1 )

$this->controls does not include the current theme in the list. So there are two easy approaches for this:

• Make the condition "> 0"
• Add the current theme as a control in class-wp-customize-manager.php

Bear in mind that in a multisite, you want to display the network activated Themes, not all the themes, just in case something extra is needed for this fix in a Multisite

[westonruter]

See #34549 for where this was originally introduced.

[westonruter]

@igmoweb you're right. In fact a bit lower in the theme it even indicates that > 0 should have been used because it adds one to the number of controls:

<span class="title-count theme-count"><?php echo count( $this->controls ) + 1 /* Active theme */; ?></span>

[westonruter]

In 35943:

Customize: Ensure that "Change" button appears when there are only 2 themes.

Fixes defect introduced in [35535].

Props igmoweb.
See #34549.
Fixes #35081.

[SergeyBiryukov]

Reopening for 4.4.1 consideration.

[dd32]

In 36065:

Customize: Ensure that "Change" button appears when there are only 2 themes.

Fixes defect introduced in [35535].

Merges [35943] to the 4.4 branch.
Props igmoweb.
See #34549.
Fixes #35081.