Opened 9 years ago
Last modified 6 years ago
#35092 reviewing defect (bug)
Remove crop check in wp_prepare_attachment_for_js() for sizes
Reported by: | markoheijnen | Owned by: | joemcgill |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.5 |
Component: | Media | Keywords: | has-patch reporter-feedback |
Focuses: | Cc: |
Description
Currently only cropped images generated on the fly are displayed. This due to a ! $downsize[3]
check. This change was made in #22598 and with the patch supplied I deleted this check. then medium/large does show up.
Attachments (1)
Change History (2)
Note: See
TracTickets for help on using
tickets.
Curious why @nacin decided to include this check in the first place as it's not obvious to me what is being avoided—full size images?
@markoheijnen could you describe a use case where this creates unexpected behavior?