WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#35110 closed defect (bug) (fixed)

Twenty Thirteen Image Attachment Page (image.php) Missing Loop

Reported by: mrwweb's profile mrwweb Owned by: swissspidy's profile swissspidy
Milestone: 4.5 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: good-first-bug has-patch
Focuses: Cc:

Description

Twenty Thirteen's image.php file uses the_ID(), the_title(), post_class(), get_the_title(), has_excerpt(), the_excerpt() the_content(), etc. yet contains no loop. This means that the template does not show the title, caption, description,

The template should have a loop added to it to properly display the image meta as one would expect on an image attachment page.

A quick test of adding the loop so that it wraps around the <article> element (before Line 16 to after Line 75) immediately fixed the issue.

Props to @deepbevel for ​noticing.

Attachments (1)

bug_35110.diff​ (6.1 KB) - added by vtieu 9 years ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
9 years ago

  • Component changed from Themes to Bundled Theme

#2 @swissspidy
9 years ago

  • Keywords needs-patch good-first-bug added
  • Version changed from 4.4 to 3.6

@vtieu
9 years ago

#3 @vtieu
9 years ago

I've added the loop on line 16 and after line 85 for the template.

#4 @swissspidy
9 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 4.5

This ticket was mentioned in ​Slack in #core by ardinent. ​View the logs.
9 years ago

#6 @swissspidy
9 years ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 36136:

Twenty Thirteen: Add missing loop in the image attachment template.

Props vtieu.
Fixes #35110.

This ticket was mentioned in ​Slack in #core-themes by davidakennedy. ​View the logs.
9 years ago

#8 @jorbin
9 years ago

  • Keywords fixed-major added
  • Milestone changed from 4.5 to 4.4.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

This has been requested for backport to 4.4.1

This ticket was mentioned in ​Slack in #core by jorbin. ​View the logs.
9 years ago

#10 @ocean90
9 years ago

  • Keywords fixed-major removed
  • Milestone changed from 4.4.1 to 4.5
  • Resolution set to fixed
  • Status changed from reopened to closed

Twenty Thirteen isn't bundled with 4.4, no need for a backport.

This ticket was mentioned in ​Slack in #core-themes by ocean90. ​View the logs.
9 years ago

Note: See TracTickets for help on using tickets.