Context Navigation

← Previous Ticket
Next Ticket →

#35110 closed defect (bug) (fixed)

Twenty Thirteen Image Attachment Page (image.php) Missing Loop

Reported by:	mrwweb	Owned by:	swissspidy
Priority:	normal	Milestone:	4.5
Component:	Bundled Theme	Version:	3.6
Severity:	normal	Keywords:	good-first-bug has-patch
Cc:		Focuses:

Description

Twenty Thirteen's image.php file uses the_ID(), the_title(), post_class(), get_the_title(), has_excerpt(), the_excerpt() the_content(), etc. yet contains no loop. This means that the template does not show the title, caption, description,

The template should have a loop added to it to properly display the image meta as one would expect on an image attachment page.

A quick test of adding the loop so that it wraps around the <article> element (before Line 16 to after Line 75) immediately fixed the issue.

Props to @deepbevel for noticing.

Attachments (1)

bug_35110.diff (6.1 KB ) - added by vtieu 11 years ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
11 years ago

Component Themes → Bundled Theme

#2 @swissspidy
11 years ago

Keywords needs-patch good-first-bug added
Version 4.4 → 3.6

@vtieu
11 years ago

Attachment bug_35110.diff added

#3 @vtieu
11 years ago

I've added the loop on line 16 and after line 85 for the template.

#4 @swissspidy
11 years ago

Keywords has-patch added; needs-patch removed
Milestone Awaiting Review → 4.5

This ticket was mentioned in Slack in #core by ardinent. View the logs.

11 years ago

#6 @swissspidy
11 years ago

Owner set to swissspidy
Resolution → fixed
Status new → closed

In 36136:

Twenty Thirteen: Add missing loop in the image attachment template.

Props vtieu.
Fixes #35110.

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.

11 years ago

#8 @jorbin
11 years ago

Keywords fixed-major added
Milestone 4.5 → 4.4.1
Resolution fixed
Status closed → reopened

This has been requested for backport to 4.4.1

This ticket was mentioned in Slack in #core by jorbin. View the logs.

11 years ago

#10 @ocean90
11 years ago

Keywords fixed-major removed
Milestone 4.4.1 → 4.5
Resolution → fixed
Status reopened → closed

Twenty Thirteen isn't bundled with 4.4, no need for a backport.

This ticket was mentioned in Slack in #core-themes by ocean90. View the logs.

11 years ago

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#35110 closed defect (bug) (fixed)

Twenty Thirteen Image Attachment Page (image.php) Missing Loop

Description

Attachments (1)

Change History (12)

#1 @SergeyBiryukov 11 years ago

#2 @swissspidy 11 years ago

@vtieu 11 years ago

#3 @vtieu 11 years ago

#4 @swissspidy 11 years ago

This ticket was mentioned in ​Slack in #core by ardinent. ​View the logs. 11 years ago

#6 @swissspidy 11 years ago

This ticket was mentioned in ​Slack in #core-themes by davidakennedy. ​View the logs. 11 years ago

#8 @jorbin 11 years ago

This ticket was mentioned in ​Slack in #core by jorbin. ​View the logs. 11 years ago

#10 @ocean90 11 years ago

This ticket was mentioned in ​Slack in #core-themes by ocean90. ​View the logs. 11 years ago