Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#35123 closed defect (bug) (fixed)

Send Trackbacks postbox: improve the visual description

Reported by: afercia Owned by: afercia
Priority: normal Milestone: 4.5
Component: Administration Version: 4.4
Severity: normal Keywords: has-screenshots has-patch
Cc: Focuses: ui, accessibility

Description

In the "Send Trackbacks" postbox, the short sentence with a "hint" about how to enter data should have a howto CSS class for visual consistency with descriptions used in other places in the admin, see for example the "Tags" postbox in the top part of the screenshot:

https://cldup.com/Fc6VS9RQGd.png

Also, it would be a nice, small, accessibility improvement using this paragraph as target for an aria-describedby attribute.

Attachments (1)

35123.patch (1.6 KB ) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (7)

@afercia
11 years ago

#1 @afercia
11 years ago

  • Keywords has-patch added

In the proposed patch:

  • improve the "Send Trackbacks" postbox using an aria-describedby attribute targeting its description
  • make the description visually consistent with other descriptions

This ticket was mentioned in Slack in #design by afercia. View the logs.


11 years ago

#3 follow-up: @michaelarestad
11 years ago

The patch looks good and much improved visually. Is there an intentional newline at the end of line 595? (code standards thing?)

#4 in reply to: ↑ 3 @afercia
11 years ago

Replying to michaelarestad:

The patch looks good and much improved visually. Is there an intentional newline at the end of line 595? (code standards thing?)

Yep, split in a new line a very long line for better readability. Was sure it was also mentioned in the coding standards but apparently is gone and now I can only see a generic reference in the JavaScript standards: ...remember the line length guidelines...

#5 @michaelarestad
11 years ago

Cool. Figured it was something like that.

#6 @afercia
11 years ago

  • Owner set to afercia
  • Resolutionfixed
  • Status newclosed

In 35983:

Accessibility: Improvements for the "Send Trackbacks" postbox.

Adds an aria-describedby attribute targeting the input field description and styles the description as a... description.

Fixes #35123.

Note: See TracTickets for help on using tickets.