WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 10 months ago

#35130 accepted defect (bug)

.wp-full-overlay-main prevents touch scrolling in theme preview iframe in iOS Safari

Reported by: anthonydpaul Owned by: obenland
Milestone: Future Release Priority: normal
Severity: normal Version: 4.4
Component: Themes Keywords: has-patch
Focuses: ui, administration Cc:

Description

This appears related to https://core.trac.wordpress.org/ticket/20805 closed 4 years ago.

In iOS 9 (latest) on an iPhone 6+ in Safari (latest) the theme previewer within the theme installer doesn't allow touch scrolling within the iframe.

This bug persists in Xcode Simulator and on iPad 2 and iPhone 6s running latest iOS and Safari.

This issue does not appear in the installed theme previewer, as far as I can tell.

Fix:
Within theme-install.php, on line 279, when I apply styles -webkit-overflow-scrolling: touch;overflow-y: scroll; to .wp-full-overlay-main it resolves the issue.

Attachments (1)

35130.diff (402 bytes) - added by obenland 21 months ago.

Download all attachments as: .zip

Change History (4)

@obenland
21 months ago

#1 @obenland
21 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.5
  • Owner set to obenland
  • Status changed from new to accepted

This seems to be an issue in both the theme install preview in core and the preview in the theme directory.

@anthonydpaul's patch works advertised, I just wonder if the overflow-y: scroll; rule will display scrollbars by default on non-Macs. Can someone with a Linux or Windows test that patch and see?

This might just be a compromise we'll have to accept to make it accessible to iOS devices.

#2 @obenland
20 months ago

  • Milestone changed from 4.5 to Future Release

#3 @mbiais
10 months ago

Looks like this one was fixed.

Note: See TracTickets for help on using tickets.