WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#35134 closed defect (bug) (fixed)

Remove title attributes: the Menus screen when no-js

Reported by: afercia Owned by: afercia
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.4
Component: Menus Keywords: has-screenshots, has-patch, title-attribute
Focuses: ui, accessibility Cc:

Description

See related #24766 and all the following tickets about title attributes.

On the "Menus" screen, only when JavaScript is off, some no-JS compatibility links appear and they have title attributes.

I'd suggest to remove the title attributes and use plain text (hidden with screen-reader-text) for the arrows, and just show the "Edit" link. See in the screenshot below, before and after the patch.

https://cldup.com/1Df0x5IZz8.png

Tried to give the "Edit" link just a basic styling, after all it's shown just when JS is off and maybe there's no need for further styling. No visual changes when JavaScript is on.

Attachments (2)

35134.patch (2.7 KB) - added by afercia 5 years ago.
35134.2.patch (2.6 KB) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (6)

@afercia
5 years ago

#1 @afercia
5 years ago

  • Keywords has-patch added
  • Owner set to afercia
  • Status changed from new to assigned

The proposed patch also removes some mixed spaces/tabs in the CSS.

@afercia
5 years ago

#2 @afercia
5 years ago

Refreshed patch to use aria-label attributes instead of text hidden with .screen-reader-text.

#3 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36016:

Accessibility: Remove title attributes and improve accessibility on the "no-js" Menus screen.

When JavaScript is off, the reorder menu item and Edit menu item links now use aria-label
attributes instead of title attributes.

Fixes #35134.

#4 @afercia
3 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.