WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#35135 closed defect (bug) (fixed)

Remove title attributes: the Link Manager screen

Reported by: afercia Owned by: afercia
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.4
Component: Administration Keywords: has-screenshots, has-patch, commit, title-attribute
Focuses: ui, accessibility Cc:

Description

See related #24766 and all the following tickets about title attributes.

The Link Manager is disabled by default since WordPress 3.5 and it can be re-enabled with the Link Manager plugin.

https://cldup.com/c4VDz5SRHo.png

The first title attribute should expand the link text using screen-reader-text, as already done for example in the Media Library list table (please notice this should be done for all similar links in the List Tables).
I'd suggest to simply remove the second title attribute. since it's a link in a "URL" column and it's clear enough.

Attachments (3)

35135.patch (2.1 KB) - added by afercia 5 years ago.
35135.2.patch (2.0 KB) - added by afercia 5 years ago.
35135.3.patch (880 bytes) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (13)

@afercia
5 years ago

#1 @afercia
5 years ago

  • Keywords has-patch added
  • Owner set to afercia
  • Status changed from new to assigned

The proposed patch fixes also some typos in the DocBlocks.

#2 @afercia
5 years ago

Discussed on Slack with the accessibility team because we noticed a bit of inconsistency in the way we're using .screen-reader-text and aria-label. Decided to stick on aria-label when the intent is to completely replace the visible text and .screen-reader-text if adding additional text.

New patch incoming.

#3 @afercia
5 years ago

  • Keywords commit added

Refreshed patch to use aria-label instead of .screen-reader-text.

@afercia
5 years ago

#4 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35998:

Accessibility: Remove title attributes from the Link Manager screen.

Title attributes are now replaced with aria-label where appropriate.
Also fixes some typos in the DocBlocks.

Fixes #35135.

This ticket was mentioned in Slack in #core by dossy. View the logs.


5 years ago

#6 @ocean90
5 years ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

The use of esc_attr_e() in [35998] is wrong, should be esc_attr().

@afercia
5 years ago

#7 @afercia
5 years ago

  • Keywords commit added

Refactored using printf(). Adds a translators comment.

This ticket was mentioned in Slack in #core by afercia. View the logs.


5 years ago

#9 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 36792:

Link Manager: Fix usage of translation functions after [35998].

Uses printf() instead, adds translator comment.

Fixes #35135.

#10 @afercia
4 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.