Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#35138 closed defect (bug) (fixed)

Tag cloud tests should be less fragile

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords:
Focuses: template Cc:


Most tests related to wp_generate_tag_cloud() test the entirety of the generated markup. This makes the tests extremely fragile. Let's make them more resilient.

Change History (2)

#1 @boonebgorges
8 years ago

In 35987:

More focused test for post_type in tag cloud links.

We should not be testing the entire tag cloud markup, as it leads to collateral
damage wheneven wp_generate_tag_cloud() is touched. See [35984].

See #25566, #35138.

#2 @boonebgorges
8 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 35988:

Better focus in tag cloud tests.

We should avoid testing complete markup strings, unless we are specifically
testing for the format of the markup.

Fixes #35138.

Note: See TracTickets for help on using tickets.