WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#35140 closed defect (bug) (fixed)

Remove title attributes: the Theme browser modal

Reported by: afercia Owned by: afercia
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.4
Component: Themes Keywords: has-screenshots, has-patch, title-attribute
Focuses: ui, accessibility Cc:

Description

See related #24766 and all the following tickets about title attributes.

When there's a Theme update available, the Theme browser modal displays a warning with a link that has a title attribute:

https://cldup.com/25VE_X2Jde.png

I'd propose to simply remove this title attribute: users already clicked on a Theme, they already know they're viewing details about "Theme xxx" (in fact, this is not the list of themes) and there's no need to specify the Theme name as context for the link.

Attachments (1)

35140.patch (3.0 KB) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (4)

@afercia
5 years ago

#1 @afercia
5 years ago

  • Keywords has-patch added
  • Owner set to afercia
  • Status changed from new to assigned

The proposed patch also adds translator comments and removes a no more used variable, see [27748].

Side note: the HTML in the translatable strings should probably be removed but that should go in a separate ticket.

#2 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36015:

Accessibility: Remove title attributes from the Theme browser.

Also, adds translators comments and removes a no more used variable, see [27748].

Fixes #35140.

#3 @afercia
3 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.