WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#35142 closed defect (bug) (fixed)

Remove title attributes and other accessibility improvements for the Authentication Check dialog "Close X"

Reported by: afercia Owned by: afercia
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.4
Component: Administration Keywords: has-screenshots, has-patch, title-attribute
Focuses: ui, accessibility Cc:

Description

See related #24766 and all the following tickets about title attributes.

The "Close X" in the authentication check modal dialog has a title attribute that says "Close". It should be replaced with some hidden text, as already done in similar cases in the admin.

Additionally, it's just a <div> element and should be a button to natively support keyboard interaction and for better semantics.

See screenshot:

https://cldup.com/Nb6DgsYKR0.png

Attachments (1)

35142.patch (1.7 KB) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @afercia
5 years ago

  • Keywords has-patch added
  • Owner set to afercia
  • Status changed from new to assigned

The proposed patch removes the title attribute and uses a <button> instead of a <div>. Also simplifies the CSS and takes care of the hover/focus style.

@afercia
5 years ago

#2 @afercia
5 years ago

Screenshot before and after the patch:

https://cldup.com/muMpLB_Uw4.png

#3 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36014:

Accessibility: Improvements for the Authentication Check modal dialog "Close X".

Removes the title attribute and uses a <button> element instead of a <div>.
Also simplifies the CSS and takes care of the hover/focus style.

Fixes #35142.

#4 @afercia
3 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.