WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 5 years ago

#35160 closed enhancement

Reorganize Feeds Unit Tests & Add Test Coverage for Atom — at Version 2

Reported by: stevenkword Owned by:
Milestone: 4.5 Priority: high
Severity: normal Version:
Component: Feeds Keywords: has-unit-tests
Focuses: Cc:

Description (last modified by stevenkword)

In Make WordPress Core, we refer to the syndication components as the "Feeds Component". However, in our unit tests, we have the group labelled in its singular form, "Feed". I proposing that we rename this group to its plural form and relocate these test into the tests/phpunit/tests/feeds/ directory.

IMPORTANT -- I don't believe svn diff has the ability to delete directories, so if this proposal is accepted, we need to make sure to manually rename/delete the 'tests/phpunit/tests/feed' directory before commit. Apologies in advance!

In addition to renaming the group, this ticket aims to separate generic syndication tests from the RSS-specific test and additionally provides test coverage for Atom feeds, which currently do not exists.

I feel it is also important to note that this will mandate a refresh of any feeds-related unit tests that are currently sitting in trac. I am willing to commit to refreshing those personally, but would prefer to hold on pending approval from the Committers.

Lastly, this patch proposes a new file, tests/phpunit/tests/feeds/common.php, which contains 3 brand new tests that will currently fail against trunk. I wanted to leave these in here to demonstrate what I was thinking with the common tests. These relate to ticket #30210. However, if I take them back out, the purpose of the common.php file becomes much less apparant. Let's discuss!

Change History (3)

@stevenkword
6 years ago

#1 @stevenkword
6 years ago

@jorbin -- You might be interested in this one.

#2 @stevenkword
6 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.