WordPress.org

Make WordPress Core

Opened 20 months ago

Last modified 18 months ago

#35182 new defect (bug)

Site icon URLs don't respect SSL in admin

Reported by: kasparsd Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.4
Component: Administration Keywords: has-patch dev-feedback https
Focuses: Cc:

Description

It appears that the following check in wp_get_attachment_url():

if ( is_ssl() && ! is_admin() && 'wp-login.php' !== $GLOBALS['pagenow'] ) {
        $url = set_url_scheme( $url );
}

prevents get_site_icon_url() from using SSL for serving the icon links in the head, which results in non-HTTPS icon URLs on all admin pages:

http://kaspars.net/wp-content/uploads/2015/12/site-icon-url-https.png

Attachments (1)

35182.diff (406 bytes) - added by kasparsd 20 months ago.
Ensure the correct URL when served via SSL

Download all attachments as: .zip

Change History (7)

@kasparsd
20 months ago

Ensure the correct URL when served via SSL

#1 @kasparsd
20 months ago

  • Keywords has-patch dev-feedback added

#2 @joemcgill
20 months ago

  • Keywords https added

Hi @kasparsd,

Thanks for the report. I believe this is the same root issue affecting #34109.

#3 @kasparsd
20 months ago

Yes, looks like it @joemcgill.

However, the attachment URLs are different because they might be inserted in post content, etc., while in this case we can safely assume that during is_ssl() the URLs should be HTTPS since they are used for HTML output only.

#4 @ocean90
18 months ago

#36119 was marked as a duplicate.

#5 @johnbillion
18 months ago

#36153 was marked as a duplicate.

This ticket was mentioned in Slack in #core by binarykitten. View the logs.


18 months ago

Note: See TracTickets for help on using tickets.