Pass nonce action from "nonce_life" filter

[giuseppe.mazzapica]

At the moment, nonce_life ​https://developer.wordpress.org/reference/hooks/nonce_life/ filter pass to callbacks only the nonce lifespan to be filtered.

There are cases in which a shorter nonce lifespan might be useful (default lifespan is one day), and would be handy being able to recognize the context for the nonce creation.

It means that wp_nonce_tick() ​https://developer.wordpress.org/reference/functions/wp_nonce_tick/ should receive the action as argument.

Providing a default (probably -1 that is the default none action) this change will be 100% backward compatible.

Currently the only (hackish) way to filter the lifespan only for specific nonces is to add a filter before to call both wp_create_nonce and wp_verify_nonce and remove the filter right after that. Two filter additions and two filter removals that may be replaced with a single filter addition if context would be provided by the nonce_life hook.

[dwainm]

First attempt at giving more context to the 'nonce_life' filter

[dwainm]

Hi @giuseppe.mazzapica , would love your feedback on the patch uploaded :)

[giuseppe.mazzapica]

Hi @dwainm, thanks.

I think there are some issues in the patch.

In wp_verify_nonce default action is -1 and probably that should be used in wp_nonce_tick as well. (And doc bloc should say string|int).

Moreover, wp_nonce_tick is used in wp_create_nonce and not only in wp_verify_nonce.

Last very minor thing, there's an alignment issue in the doc bloc.

[dwainm]

Updated doc blocks and added argument to wp_create_nonce function call to wp_nonce_tick call

[dwainm]

Thank you for your feedback @giuseppe.mazzapica . Updated :)

[dwainm]

Hi @giuseppe.mazzapica @johnbillion

I would love to your feedback on the latest patch. Thank you.

[DrewAPicture]

Assigning to mark the good-first-bug as "claimed".

See 35188-2.patch​

[jorbin]

Thanks for the patch. When a filter or function's signature is updated, the inline documentation should be updated with a ​changelog entry. Additionally, the patch uses spaces and not tabs, so it needs to be updated for that well. The ​PHP style guide is in the handbook.

[dwainm]

35188-patch-3

[dwainm]

Adding changelog entries

[dwainm]

Thank you for your feedback @jorbin. I've updated the patch to include tabs not space and have updated the change log for both the function and the filter.