WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#35194 closed defect (bug) (fixed)

Remove embed discovery tags from HTML header of static home pages

Reported by: peterwilsoncc Owned by: pento
Milestone: 4.4.1 Priority: normal
Severity: normal Version: 4.4
Component: Embeds Keywords: has-patch has-unit-tests fixed-major
Focuses: Cc:
PR Number:

Description

It's not possible to embed a static front page, see #34971.

Attached patch prevents the discovery headers from showing on the front page.

Attachments (2)

35194.diff (549 bytes) - added by peterwilsoncc 4 years ago.
35194.2.diff (1.7 KB) - added by peterwilsoncc 4 years ago.

Download all attachments as: .zip

Change History (9)

@peterwilsoncc
4 years ago

#1 @peterwilsoncc
4 years ago

  • Keywords has-patch added

#2 @johnbillion
4 years ago

  • Keywords needs-unit-tests added

+1.

There are some tests for this in Tests_oEmbed_Discovery that could be added to.

#3 @peterwilsoncc
4 years ago

  • Keywords has-unit-tests added; needs-unit-tests removed

Unit tests added in 35194.2.diff.

Includes home page tests for both show_on_front settings.

#4 @pento
4 years ago

  • Owner set to pento
  • Status changed from new to assigned

#5 @pento
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36059:

Embeds: Don't show embed discovery link on a static front page.

There's currently no iframe content being generated for a static front page. Giving out a link to that isn't an ideal user experience.

Props peterwilsoncc.

Fixes #35194 for trunk.

#6 @pento
4 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @pento
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 36060:

Embeds: Don't show embed discovery link on a static front page.

There's currently no iframe content being generated for a static front page. Giving out a link to that isn't an ideal user experience.

Props peterwilsoncc.

Merge of [36059] to the 4.4 branch.

Fixes #35194.

Note: See TracTickets for help on using tickets.