WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#35234 closed defect (bug) (fixed)

WP::remove_query_var()

Reported by: swissspidy Owned by: swissspidy
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Query Keywords: has-patch has-unit-tests commit
Focuses: Cc:

Description

As suggested in 35227#comment:3, it's worth adding a WP::remove_query_var() helper to make it easier cleaning up public query vars.

Attachments (1)

35234.diff (1.6 KB) - added by swissspidy 5 years ago.

Download all attachments as: .zip

Change History (7)

@swissspidy
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to Query

#2 @boonebgorges
5 years ago

Patch looks good to me.

Can we add the new tests to a @group? It seems odd to have orphaned tests. Maybe @group wp?

#3 @swissspidy
5 years ago

  • Keywords commit added

@group wp sounds good to me. Shall I update the patch or add it when committing?

#4 @boonebgorges
5 years ago

On commit is OK with me.

#5 @swissspidy
5 years ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 36177:

Query: Add a WP::remove_query_var() helper function.

This makes cleaning up public query vars easier.

Fixes #35234.

#6 @DrewAPicture
4 years ago

In 36900:

Docs: Improve the DocBlock summary for WP::remove_query_var(), introduced in [36177].

See #35234. See #35986.

Note: See TracTickets for help on using tickets.