get_the_terms return on non-existing term

[tivnet]

<?php
function get_the_terms( $post, $taxonomy ) {
        if ( ! $post = get_post( $post ) )
                return false;

        $terms = get_object_term_cache( $post->ID, $taxonomy );
        if ( false === $terms ) {
                $terms = wp_get_object_terms( $post->ID, $taxonomy );

// ---------- PROPOSED (should we return WP_Error or false here?)

                if ( is_wp_error( $terms ) ) {
                        return $terms;
                }

// ----------

                $to_cache = array();

[tivnet]

Patch returning WP_Error

[swissspidy]

Related: #34723

[tivnet]

* @return array|false|WP_Error Array of term objects on success, false if there are no terms
*                              or the post does not exist, WP_Error on failure.

This description suggests that false should be returned.

However, if I am not mistaken, I was getting WP_Error in this case before 4.4

[tivnet]

Replying to swissspidy:

Related: #34723

Yep, that's the same case. Not sure, still, if need to return WP_Error as it was before (according to my tests).

Thank you!

[swissspidy]

Replying to tivnet:

* @return array|false|WP_Error Array of term objects on success, false if there are no terms
*                              or the post does not exist, WP_Error on failure.

This description suggests that false should be returned.

However, if I am not mistaken, I was getting WP_Error in this case before 4.4

It clearly suggests that it returns either false or a WP_Error object, so I don't see a problem here.

There are is_wp_error checks later on and the get_the_terms filter clearly says that $terms can be a WP_Error object.

Long story short: Your patch prevents the get_the_terms filter being called, otherwise nothing else changes.

[tivnet]

Replying to swissspidy:

Long story short: Your patch prevents the get_the_terms filter being called, otherwise nothing else changes.

The main idea was to avoid notice on non-array.

[tivnet]

Specifically:

Notice: Trying to get property of non-object in wp-includes\category-template.php on line 1153

($term->data)

[boonebgorges]

I'm pretty sure this is a duplicate of #34723, and should be fixed by [35850].

[tivnet]

Replying to boonebgorges:

I'm pretty sure this is a duplicate of #34723, and should be fixed by [35850].

Yes, 4.4.1 fixed this. Thanks