WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 2 years ago

#35304 closed defect (bug) (fixed)

Remove title attributes: the Comments screens

Reported by: afercia Owned by: afercia
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.4
Component: Administration Keywords: has-patch, has-screenshots, title-attribute
Focuses: ui, accessibility Cc:

Description

See related #24766 and all the following tickets about title attributes.

In the Comments screens, the action links for each comment have title attributes that mostly repeat the information already provided by the link text. There's also a bit of inconsistency between the terms "comment", "this comment", and "this item". Some links have no title attribute at all. See screenshot:

https://cldup.com/C9VtI78mNX.png

I'd propose to simply remove all the title attributes because visually they don't help so much. For accessibility, each link should be expanded to give some context about the item it is related to. Unfortunately, comments don't have a title so I can't think of any proper text to use other than "this comment". Any thoughts more than welcome.

Attachments (2)

35304.patch (6.6 KB) - added by afercia 4 years ago.
35304.2.patch (6.6 KB) - added by afercia 4 years ago.

Download all attachments as: .zip

Change History (10)

@afercia
4 years ago

#1 @afercia
4 years ago

  • Keywords has-patch has-screenshots added
  • Owner set to afercia
  • Status changed from new to assigned

First pass.

#2 follow-up: @afercia
4 years ago

Not sure about the string Mark this comment as not spam. Searched for similar strings and found You are about to unspam the site %s. but to be honest I'm not sure if "unspam" is proper English. Possible alternate string: Restore this comment from the Spam.
Would greatly appreciate some feedback :)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#5 in reply to: ↑ 2 @afercia
4 years ago

Replying to afercia:

Not sure about the string Mark this comment as not spam.

Discussed a bit this point in the last accessibility team weekly chat and agreed to use a sentence with a positive action rather than a "not". Since there are already strings like:

`%s: number of comments restored from the spam`
`%s comment restored from the spam`
`%s comments restored from the spam`

the preference was for Restore this comment from the Spam.

@afercia
4 years ago

#6 @afercia
4 years ago

Patch refreshed with the new string.

#7 @afercia
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36298:

Accessibility: Remove title attributes from the Comments screen.

Fixes #35304.

#8 @afercia
2 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.