WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 2 years ago

#35313 closed defect (bug) (fixed)

Remove title attributes: Posts, Pages, and CPTs screens

Reported by: afercia Owned by: afercia
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.4
Component: Administration Keywords: has-patch, has-screenshots, commit, title-attribute
Focuses: ui, accessibility Cc:

Description

See related #24766 and all the following tickets about title attributes.

In edit.php, the item title link and the action links have title attributes that mostly repeat the information already provided by the links.

Title attributes that say "this item" don't help so much sighted users since they can actually see what item these links refers to. On the other hand, for accessibility these links should provide more information and make sense even when read out of context.

https://cldup.com/--PeMMzG7b.png

I'd propose to simply remove all the title attributes and use aria-label attributes as done for other similar screens (e.g. Plugins).

A special case in these screens is the Published date: in the "List View" there's an abbreviation with a title attribute that repeats the date and adds the time. In the "Excerpt View", the time is displayed in plain text next to the date. Pages don't have the "Excerpt View".

https://cldup.com/ewptMGK9HM.png

Worth reminding title attributes on not-focusable elements won't be announced by screen readers. Please also consider touch devices, tablet, smartphones, where title attributes are hardly useful.

If the published time is a relevant information, I'd say it should be displayed in plain text. Title attributes are the best way to hide content from users :)

By the way, I guess this would need some discussion so I'll open a separate ticket.

Attachments (3)

35313.patch (5.6 KB) - added by afercia 4 years ago.
35313.2.patch (5.9 KB) - added by afercia 4 years ago.
35313.3.patch (5.3 KB) - added by afercia 4 years ago.

Download all attachments as: .zip

Change History (14)

@afercia
4 years ago

#1 @afercia
4 years ago

  • Keywords has-patch has-screenshots added
  • Owner set to afercia
  • Status changed from new to assigned

First pass. Also, adds translator comments and splits long lines for better readability.

Last edited 4 years ago by afercia (previous) (diff)

@afercia
4 years ago

#2 @afercia
4 years ago

  • Keywords commit added

Refreshed patch, uses sprintf() to build the links strings.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#4 follow-up: @Cheffheid
4 years ago

Is there a reason why the date display isn't consistent between both views? I mean, the discussion on #35050 on what it should be aside, shouldn't it at least be consistent? (Sorry, rabbit-hole, should probably be a separate ticket :))

Beyond that, it seems to work as expected in FireFox/NVDA and no other title attributes seem to remain.

I do have one more question about the code, but otherwise unrelated to the ticket, is there a reason you're using printf() on line 880, but sprintf() everywhere else?

Last edited 4 years ago by Cheffheid (previous) (diff)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#6 in reply to: ↑ 4 @afercia
4 years ago

Replying to Cheffheid:

Is there a reason why the date display isn't consistent between both views? I mean, the discussion on #35050 on what it should be aside, shouldn't it at least be consistent? (Sorry, rabbit-hole, should probably be a separate ticket :))

Who knows :) I think it was done during the crazy horse redesign (WP 2.7), created a specific ticket see #35391.

@afercia
4 years ago

#7 @afercia
4 years ago

As done in #35136 the refreshed patch strips out changes to the Comments "bubble". Icon links need a way to clarify what they represent. By the way, this issue is related to all icon links used in the admin so it should probably go in a separate ticket.

#8 @afercia
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36333:

Accessibility: Remove title attributes from the Posts list table.

Fixes #35313.

#9 @afercia
4 years ago

In 36334:

After [36333] correctly use esc_attr() instead of esc_attr__().

See #35313.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#11 @afercia
2 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.