Opened 9 years ago
Closed 9 years ago
#35320 closed enhancement (fixed)
Customizer closes when you activate a new theme
Reported by: | melchoyce | Owned by: | westonruter |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Customize | Keywords: | has-patch commit |
Focuses: | ui | Cc: |
Description
When you switch to a new theme in the Customizer and hit "Save and Activate," the Customizer closes.
Steps to reproduce:
- Enter the Customizer
- Next to Active Theme, click "Change"
- Change to a different theme
- Click "Save and Activate"
- The Customizer closes
What I expect to happen: Since I'm changing my theme from the Customizer, I epxect the Customizer to remain open so I can continue working on my site.
Attachments (1)
Change History (8)
#2
@
9 years ago
- Focuses ui added
- Keywords needs-patch added
- Milestone changed from Awaiting Review to Future Release
- Version set to 4.2
I would definitely be in favor of removing this functionality. It assumes that all customization work is complete once a new theme is activated, but in reality additional tweaks may be necessary, and the front end remains visible in the preview. I would argue that the fact that themes can be changed within the Customizer now (since 4.2) makes this old feature become unexpected and jarring. Users have the expectation that they stay in the customizer when they hit the save button, regardless of whether it says "publish" or "activate."
#4
@
9 years ago
- Milestone changed from Future Release to 4.6
Unless anyone feels strongly that the customizer should close when a new theme is activated, let's get 35320.diff in.
#5
@
9 years ago
+1 for the Customizer remaining open following activation of a theme.
I've hit this a couple of times myself and always found that experience strangely unlike other save actions in the Customizer.
This functionality was specifically developed for the Customizer:
This has been in place since the Customizer was initially introduced in 3.4. Looking back in the source, I see it was implemented for #20743. The ticket doesn't have much of a rationale for why this behavior was needed.
In any case, I think the current behavior is not a bug but a feature (literally). However, the Customizer may have outlived this feature and it may no longer be applicable.